installs wrong package in cc_salt_minion.py

Bug #996166 reported by akoumjian@gmail.com
22
This bug affects 3 people
Affects Status Importance Assigned to Milestone
cloud-init
Fix Released
Medium
Scott Moser
cloud-init (Ubuntu)
Fix Released
Medium
Unassigned
Precise
Won't Fix
Medium
Unassigned

Bug Description

The salt ppa uses the package name "salt-minion" while the handler tries to install the old package name "salt".

http://bazaar.launchpad.net/~cloud-init-dev/cloud-init/trunk/view/head:/cloudinit/CloudConfig/cc_salt_minion.py#L30

Revision history for this message
Jeff Bauer (jbauer) wrote :
Revision history for this message
akoumjian@gmail.com (akoumjian) wrote :

Just wanted to bump this. For people who want to use salt with cloud-init, this is critical.

Revision history for this message
Jeff Bauer (jbauer) wrote :

Agreed with akoumjian. Without this fix, salt is unusable with cloud-init.

Revision history for this message
akoumjian@gmail.com (akoumjian) wrote :

Bumping this. Getting salt working in cloud-init is about to become more relevant as salt will be landing in 12.10.

Revision history for this message
Scott Moser (smoser) wrote :

Jeff,
  FWIW, the source and target of your merge proposal were reversed. You had requested that lp:cloud-init be merged into lp:~jbaur/cloud-init/salt.

I've gone ahead and taken the necessary change and committed it to trunk.

--- cloudinit/CloudConfig/cc_salt_minion.py 2012-02-17 15:04:49 +0000
+++ cloudinit/CloudConfig/cc_salt_minion.py 2012-06-20 18:04:27 +0000
@@ -27,7 +27,7 @@
         return
     salt_cfg = cfg['salt_minion']
     # Start by installing the salt package ...
- cc.install_packages(("salt",))
+ cc.install_packages(("salt-minion",))
     config_dir = '/etc/salt'
     if not os.path.isdir(config_dir):
         os.makedirs(config_dir)

Changed in cloud-init:
status: New → Fix Committed
importance: Undecided → Medium
assignee: nobody → Scott Moser (smoser)
Scott Moser (smoser)
Changed in cloud-init (Ubuntu):
status: New → Fix Released
importance: Undecided → Medium
Changed in cloud-init (Ubuntu Precise):
status: New → Triaged
importance: Undecided → Medium
Scott Moser (smoser)
Changed in cloud-init:
status: Fix Committed → Fix Released
Revision history for this message
Scott Moser (smoser) wrote :

As far as I can tell, this is fix-released in precise.
It must have regressed and the been fixed in quantal's lifetime.

Please re-open if that is incorrect and I will sru this.

Changed in cloud-init (Ubuntu Precise):
status: Triaged → Fix Released
Revision history for this message
Charles Mulder (charlesmulder) wrote :

Still getting this error when using EC2 Ubuntu 12.04 ami with the following cloud-init:

#cloud-config

apt_sources:
  - source: "ppa:saltstack/salt"

apt_update: true

packages:
  - salt-minion

apt_upgrade: true

salt_minion:
  conf:
    master: master.nerdcorp.co.za

runcmd:
  - service salt-minion start

Revision history for this message
Scott Moser (smoser) wrote :

if you want to get this SRU'd to precise (12.04) we have to follow StableReleaseProcess guidelines
https://wiki.ubuntu.com/StableReleaseUpdates

We need a template added to this bug.

Changed in cloud-init (Ubuntu Precise):
status: Fix Released → Confirmed
Revision history for this message
Scott Moser (smoser) wrote :

It actually seems like it might be best to *not* fix it in 12.04.
* You can easily add a 'salt' metapackage to the ppa which would fix it
* there is no 'salt' or salt-minion package in 12.04 its not explicitly *wrong* there.
* There isn't an easy way to make this change without breaking someone's 12.04 stuff that included a package named 'salt' in the archive.

Can you just change the archive?

Revision history for this message
Steve Langasek (vorlon) wrote :

The Precise Pangolin has reached end of life, so this bug will not be fixed for that release

Changed in cloud-init (Ubuntu Precise):
status: Confirmed → Won't Fix
Revision history for this message
James Falcon (falcojr) wrote :
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.