linaro-license-protection

Integration tests fail

Bug #996002 reported by Stevan Radaković
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
linaro-license-protection
Fix Released
Critical
Stevan Radaković
linaro-license-protection 2012.05

Bug Description

Upon running the python integration tests with 'testr run', a number of 19 failed asserts are displayed.
All of the failed tests are in the testing/test_click_through_license.py file.
This may have to do something with the non-up-to-date version of the filefetcher.py.

Errors linked here https://pastebin.linaro.org/522/

See original description

Related branches

lp:~stevanr/linaro-license-protection/automate-integration-tests
James Tunnicliffe (community): Approve
Данило Шеган: Pending (code) requested
Diff: 517 lines (+305/-143)
5 files modified
.htaccess (+2/-2)
README (+7/-0)
testing/filefetcher.py (+0/-129)
testing/license_protected_file_downloader.py (+284/-0)
testing/test_click_through_license.py (+12/-12)
Stevan Radaković (stevanr)
description: updated
Revision history for this message
Данило Шеган (danilo) wrote :

Regression tests that fail aren't. We need to fix this asap.

Changed in linaro-license-protection:
status: New → Triaged
importance: Undecided → Critical
milestone: none → 2012.05
Georgy Redkozubov (gesha)
Changed in linaro-license-protection:
assignee: nobody → Georgy Redkozubov (gesha)
Данило Шеган (danilo)
Changed in linaro-license-protection:
assignee: Georgy Redkozubov (gesha) → Stevan Radaković (stevanr)
Revision history for this message
Данило Шеган (danilo) wrote :

Stevan, please talk to James and Deepti to get the latest filefetcher.py which is required to make the tests pass. Most important thing is to get the tests passing, so do not dwell on reviewing and fixing it if there are some problems with it.

Revision history for this message
James Tunnicliffe (dooferlad) wrote : Re: [Bug 996002] Re: Integration tests fail

I pointed Deepti to a work in progress script. I think she mostly
split it into a couple of files in lp:linaro-ci

My work in progress is:
http://bazaar.launchpad.net/~dooferlad/linaro-fetch-image/add-license-accept/view/head:/linaro_fetch_image/license_protected_file_downloader.py

The CI scripts are:
http://bazaar.launchpad.net/~linaro-infrastructure/linaro-ci/lci-build-tools/view/head:/download_content_yes_to_lic.py
http://bazaar.launchpad.net/~linaro-infrastructure/linaro-ci/lci-build-tools/view/head:/download_file

I think the scripts in CI are just the script from fetch-image split
into two, so you should be able to replace the current filefetcher.py
with license_protected_file_downloader.py (keep the old name if you
like). We do need a canonical source for this file, so hopefully it
will be in the license protection code and CI and Fetch Image can use
a bzr external to pull it into those projects.

Stevan Radaković (stevanr)
Changed in linaro-license-protection:
status: Triaged → Fix Committed
Stevan Radaković (stevanr)
Changed in linaro-license-protection:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.