elementary OS

Rename slingshot to slingshot-launcher

Bug #993044 reported by ttosttos on 2012-05-02

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Cerbere	Fix Released	Undecided	Cody Garver	Cerbere 0.1 "howling at the Luna"
Gala	Fix Released	Undecided	Cody Garver	Gala luna-0.2
Slingshot	Fix Released	Undecided	Cody Garver	Slingshot 0.7 "Donatello"
Wingpanel	Fix Released	Low	Cody Garver	Wingpanel 0.1-alpha2
elementary OS	Fix Released	Undecided	Cody Garver	elementary OS luna-beta1

Bug Description

A subset of the core apps should be identified as core system apps and be built with unique names to prevent app conflicts that could render the system unusable or confuse user. A prefix (e.g. pantheon-slingshot or elementary-slingshot) could be used for name differentiation. As an example, Ubuntu repositories have a slingshot game available today. If an user accidentally or purposely installs the game, elementary slingshot app would be overwritten. The following core apps would candidates to be flagged as core system apps: slingshot, wingpanel, cerbere, contractor, switchboard.

Related branches

lp:~codygarver/slingshot/fix-993044

Merged into lp:~elementary-pantheon/slingshot/trunk at revision 235

Victor Martinez (community): Approve on 2012-07-10

lp:~codygarver/cerbere/fix-993044

Merged into lp:~elementary-pantheon/cerbere/cerbere at revision 35

Victor Martinez (community): Approve on 2012-07-10

lp:~codygarver/wingpanel/fix-993044

Merged into lp:~elementary-pantheon/wingpanel/old-trunk at revision 86

Victor Martinez (community): Approve on 2012-07-10

lp:~codygarver/elementaryos/pantheon-xsession-settings-fix-993044

Merged into lp:~elementary-os/elementaryos/pantheon-xsession-settings-luna at revision 53

Cody Garver (community): Approve on 2012-07-11

Revision history for this message

Sergey "Shnatsel" Davidoff (shnatsel) wrote on 2012-05-02:

Packages are not allowed to overwrite each other unless they explicitly request it. E.g. our "slingshot-launcher" package doesn't conflict with "slingshot" from Ubuntu repos because "slingshot" is a game and it's installed in /usr/games/.

Well, somebody following your logic made slingshots conflict on packaging level, but I've fixed that yesterday and the fix will land to the PPA in an hour or so. I'll check if there are any file collisions (e.g. in .desktop files) and fix them if I encounter any.

Revision history for this message

ttosttos (ttosttos) wrote on 2012-05-02:

As of the Luna unstable 20120427, running 'apt-get install slingshot' had the very undesirable effect of launching a game when clicking on "Applications" on Wingpanel. No error, no warning presented to the user. While this game is just an example, we should think more generally to see how likely are conflicts.

Revision history for this message

Sergey "Shnatsel" Davidoff (shnatsel) wrote on 2012-05-02:

Why would you run 'apt-get install slingshot' on a daily build in the first place?

Revision history for this message

Sergey "Shnatsel" Davidoff (shnatsel) wrote on 2012-05-02:

Oh, I see the problem now. Thanks!
Hmm... I guess Wingpanel should try launching full path. This is weird because /usr/games is the last entry in PATH environment variable, at least on my elementaryfied Precise.

summary:

- Uniquely name core system apps
+ Use full paths to binaries internally

Revision history for this message

Sergey "Shnatsel" Davidoff (shnatsel) wrote on 2012-05-02: Re: Use full paths to binaries internally

Could you please run "echo $PATH" in terminal and post output?

Revision history for this message

ttosttos (ttosttos) wrote on 2012-05-03:

ttosttoss@aburra:~$ echo $PATH
/usr/lib/lightdm/lightdm:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games
ttosttoss@aburra:~$

Maybe the game isn't really installing under /usr/games ?

Revision history for this message

Sergey "Shnatsel" Davidoff (shnatsel) wrote on 2012-05-03:

Thanks! Please check if you still have "slingshot-launcher" package installed. It could get removed by installing "slingshot" in some older builds.

Revision history for this message

Danielle Foré (danrabbit) wrote on 2012-05-31:

marking as incomplete until we can find out if this is still happening with the latest packaging.

Changed in elementaryos:
status:	New → Incomplete

Revision history for this message

Sergey "Shnatsel" Davidoff (shnatsel) wrote on 2012-05-31:

Should be done regardless of packaging. Just a common sense and robustness improvement.

Changed in elementaryos:
status:	Incomplete → Confirmed

Cody Garver (codygarver) on 2012-07-08

summary:	- Use full paths to binaries internally + Rename slingshot to slingshot-launcher
Changed in slingshot:
status:	New → In Progress
Changed in wingpanel:
status:	New → In Progress
Changed in cerbere:
status:	New → In Progress
assignee:	nobody → Cody Garver (codygarver)
Changed in slingshot:
assignee:	nobody → Cody Garver (codygarver)
Changed in wingpanel:
assignee:	nobody → Cody Garver (codygarver)

Danielle Foré (danrabbit) on 2012-07-09

Changed in cerbere:
milestone:	none → luna-beta1

Cody Garver (codygarver) on 2012-07-11

Changed in elementaryos:
assignee:	nobody → Cody Garver (codygarver)
Changed in gala:
assignee:	nobody → Cody Garver (codygarver)
status:	New → Fix Released
milestone:	none → luna-beta1
Changed in slingshot:
status:	In Progress → Fix Committed
Changed in wingpanel:
status:	In Progress → Fix Committed
Changed in elementaryos:
status:	Confirmed → Fix Committed
Changed in cerbere:
status:	In Progress → Fix Committed

Cody Garver (codygarver) on 2012-07-11

Changed in slingshot:
milestone:	none → luna-beta1
Changed in wingpanel:
milestone:	none → luna-beta1
Changed in elementaryos:
milestone:	none → luna-beta1

Danielle Foré (danrabbit) on 2012-07-11

Changed in cerbere:
status:	Fix Committed → Fix Released

Revision history for this message

alexander (shootnix-i) wrote on 2012-07-12:

#10

After update wingpanel slingshot launcher doesn't run, just opened window in /usr/share/application.

Revision history for this message

Cody Garver (codygarver) wrote on 2012-07-12:

#11

dconf reset -f /org/pantheon/desktop/

Revision history for this message

Sergey "Shnatsel" Davidoff (shnatsel) wrote on 2012-07-12:

#12

Correction: dconf reset -f /org/pantheon/desktop/wingpanel

Revision history for this message

Victor Martinez (victored) wrote on 2012-07-13:

#13

Since this change affects cerbere, slingshot, etc, resetting the entire /desktop/ path is more appropriate, as Cody suggested.

Revision history for this message

Sergey "Shnatsel" Davidoff (shnatsel) wrote on 2012-07-15:

#14

Cerbere is not even in /org/pantheon/desktop/ and resetting the whole desktop/ is an overkill anyway.

So the correct commands are:
dconf reset -f /org/pantheon/desktop/wingpanel
dconf reset -f /org/pantheon/cerbere

David Gomes (davidgomes) on 2012-09-29

Changed in wingpanel:
importance:	Undecided → Low

Danielle Foré (danrabbit) on 2012-11-09

Changed in slingshot:
status:	Fix Committed → Fix Released

Sergey "Shnatsel" Davidoff (shnatsel) on 2012-12-10

Changed in elementaryos:
status:	Fix Committed → Fix Released

Sergey "Shnatsel" Davidoff (shnatsel) on 2012-12-10

Changed in wingpanel:
status:	Fix Committed → Fix Released

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.