Launchpad itself

Special permissions for 'Archive.commercial' are not needed

Bug #992691 reported by Jonathan Lange
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Jonathan Lange

Bug Description

At the moment, software_center_agent has special permissions to view and upload to commercial archives. It doesn't need these things as it always owns the archives that it creates & manages. It only needs special perms to view subscription URLs.

Related branches

lp:~jml/launchpad/drop-special-commercial-permissions
Anthony Lenton (community): Approve
William Grant: Approve (code)
James Westby (community): Approve
Richard Harding (community): Approve (code)
Diff: 113 lines (+15/-40)
3 files modified
lib/lp/security.py (+0/-8)
lib/lp/soyuz/stories/webservice/xx-archive-commercial.txt (+5/-3)
lib/lp/soyuz/tests/test_archive_agent.py (+10/-29)
Laura Czajkowski (czajkowski)
Changed in launchpad:
status: New → Triaged
importance: Undecided → High
Jonathan Lange (jml)
Changed in launchpad:
status: Triaged → In Progress
assignee: nobody → Jonathan Lange (jml)
Revision history for this message
Jonathan Lange (jml) wrote :

NOTE: Please don't mark this as qa-ok without first checking with the Consumer Apps server team, specifically ~elachuni.

Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r15205 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15205>.

tags: added: qa-needstesting
Changed in launchpad:
status: In Progress → Fix Committed
Revision history for this message
Michael Nelson (michael.nelson) wrote :

Just some deveolper QA notes I should have pasted on the bug in the first place. Waiting for our QA person to verify with a new PPA also:

We can now QA on lp-staging [1]. I sync'd the logs and
process-payment-notifications.log looks normal, although obviously
it's got nothing to process. So just to check things are ready for
davmor, I tried a purchase of hellox [3] using one of the rbs world
pay fake credit card numbers [4], saw the "waiting for information"
then "Payment Authorised" messages, but then:

Failure in the purchase process. Sorry, something went wrong. Your
payment has been cancelled.

Checking the logs for the payment processor on staging shows that
either the credentials for staging sca aren't up to date, or we have a
problem. Most likely the former, but I'll keep investigating now.

Or the staging software-center-agent user isn't a member of the team
owning the test PPA (canonical-isd-hackers). After hloeng added the
staging software-center-agent user to the staging
canonical-isd-hackers team, I retried the purchase and the
subscription completed [5] :-)

So, over to you Dave to check with a new PPA that is private-only etc.

[1] jml's branch landed in lp-stable 15205 which was merged into
db-stable with r11572, and staging.launchpad.net tells us it's
currently running r11573.
[3] `rm -rf ~/.cache/software-center` then
`SOFTWARE_CENTER_BUY_HOST=https://sc.staging.ubuntu.com
software-center`, then purchase Test App2 (hellox).
[4] http://www.worldpay.com/support/kb/bg/testandgolive/tgl5103.html
[5] https://pastebin.canonical.com/65588/

James Westby (james-w)
tags: added: qa-ok
removed: qa-needstesting
Steve Kowalik (stevenk)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.