The current code layout makes it hard to separate the tests per-platform (messaging)
Bug #989122 reported by
Diego Sarmentero
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Ubuntu One Client |
Fix Released
|
High
|
Diego Sarmentero | ||
Bug Description
The current code layout makes it impossible/hard to separate the tests per-platform. The suggested solution is:
Refactor this module to have something like:
messaging/
__init__.py
linux.py
windows.py
darwin.py
Refactor the Tests for this module in the same way.
Related branches
lp:~diegosarmentero/ubuntuone-client/refactor-messaging
- Eric Casteleijn (community): Approve
- Manuel de la Peña (community): Approve
-
Diff: 212 lines (+92/-68)6 files modifiedtests/platform/messaging/__init__.py (+27/-0)
tests/platform/messaging/test_linux.py (+1/-1)
ubuntuone/platform/messaging/__init__.py (+2/-4)
ubuntuone/platform/messaging/windows.py (+62/-0)
ubuntuone/platform/windows/__init__.py (+0/-1)
ubuntuone/platform/windows/messaging.py (+0/-62)
| summary: |
- Refactor platform/messaging + The current code layout makes it hard to separate the tests per-platform + (messaging) |
| description: | updated |
| Changed in ubuntuone-client: | |
| status: | New → Triaged |
| tags: | added: desktop+ |
| Changed in ubuntuone-client: | |
| assignee: | Mike McCracken (mikemc) → Diego Sarmentero (diegosarmentero) |
| Changed in ubuntuone-client: | |
| status: | Triaged → In Progress |
| Changed in ubuntuone-client: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntuone-client: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
