Rawstudio

gphoto fails to download image from camera

Bug #981062 reported by Gareth Williams on 2012-04-13

This bug affects 3 people

	Status	Importance	Assigned to	Milestone
Rawstudio	New	Undecided	Unassigned
libgphoto2 (Ubuntu)	Fix Released	Undecided	Unassigned
Precise	Fix Released	Low	Unassigned	Ubuntu ubuntu-12.04.1

Bug Description

libgphoto2-2 should be upgraded to the latest version - 2.4.14

[Impact]

Users of Canon EOS (Rebel) series cameras cannot download images remotely from their cameras to their computers.

[Test Case]

The command:-

gphoto --capture-image-and-download

causes the camera takes a photo, but then gphoto hangs. If I use Ctl-C to stop gphoto, I get:-

ERROR: Could not get image.
ERROR: Buggy libcanon.so?

The result should be that gphoto downloads the image to the PC and deletes it on the camera.

This works again if libgphoto2 is upgraded to version 2.4.14, which is available in Quantal.

[Regression Potential]

The potential for regression will be limited by the fact that it only affects libgphoto users. Worst case is that other cameras may stop working if a new, unkown bug is lurking in the library.

Bug was raised (and closed) on Sourceforge for the gphoto2 package and is visible at:-
http://sourceforge.net/tracker/index.php?func=detail&aid=3541332&group_id=8874&atid=108874

Apparently, this bug was inserted into 2.4.13 which has since been fixed in 2.4.14
The latest (pre 2.4.13) version I used was 2.4.11 in Oneric, which also works.

TEST CASE
1. Confimed that libgphoto2 version 2.4.13-1ubuntu1 was installed on my machine.
2. Ran the command: gphoto --capture-image-and-download
3. Image failed to download
4. Set up apt to use precise-proposed
5. Upgraded libgphoto2 to version 2.4.13-1ubuntu1.1
6. Ran the command: gphoto --capture-image-and-download
VERIFICATION DONE
1. Image successfully downloaded.

See original description

Tags:

Related branches

lp:~gareththered/ubuntu/precise/libgphoto2/fix-for-981062

lp:ubuntu/precise-proposed/libgphoto2

Revision history for this message

Gareth Williams (gareththered) wrote on 2012-04-13:

Dependencies.txt Edit (1.4 KiB, text/plain; charset="utf-8")

Revision history for this message

Gareth Williams (gareththered) wrote on 2012-04-13:

I downloaded libgphoto2-2_2.4.11-3_i386.deb for Ubuntu 11.10 and installed it. Now the camera takes photos and downloads them to the camera.

I then used:

sudo apt-get dist-upgrade

to restore the original version to libgphoto2-2_2.4.13-1ubuntu1_i386.deb and the bug returns.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2012-07-08:

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in gphoto2 (Ubuntu):
status:	New → Confirmed

Revision history for this message

Gareth Williams (gareththered) wrote on 2012-07-09:

I raised an issue up-stream with gphoto2 and was informed that this issue was inadvertently created in version 2.4.13 and has since been fixed in the latest version - 2.4.14

This latest version is available in the Ubuntu 12.10 (quantal) repository and I've pinned libgphoto2-2 to this version for now.

Gareth Williams (gareththered) on 2012-07-09

description:

updated

Revision history for this message

Micah Gersten (micahg) wrote on 2012-07-09:

Fixed with 2.4.14-1 in quantal apparently

tags:	added: regression-release
Changed in gphoto2 (Ubuntu):
status:	Confirmed → Fix Released
Changed in gphoto2 (Ubuntu Precise):
importance:	Undecided → Low

Sebastien Bacher (seb128) on 2012-07-09

Changed in gphoto2 (Ubuntu Precise):
status:	New → Triaged

Revision history for this message

Sebastien Bacher (seb128) wrote on 2012-07-09:

The new version has a too many changes to be uploaded as a stable update, figuring what commit is needed would be nice

Sebastien Bacher (seb128) on 2012-07-10

Changed in gphoto2 (Ubuntu Precise):
milestone:	none → ubuntu-12.04.1

Revision history for this message

Gareth Williams (gareththered) wrote on 2012-07-10:

85-fix-hang-during-file-download.patch Edit (735 bytes, text/plain)

I've extracted two lines from up-stream v2.4.14 and added them to v.2.4.13-1ubuntu1 and it has fixed the issue. I've attached these to this bug report as a patch.

Revision history for this message

Gareth Williams (gareththered) wrote on 2012-07-11:

Debdiff Edit (2.3 KiB, text/plain)

I've attached a debdiff for this issue.

Marc Deslauriers (mdeslaur) on 2012-07-11

Changed in libgphoto2 (Ubuntu):
status:	New → Fix Released
Changed in libgphoto2 (Ubuntu Precise):
status:	New → Triaged
importance:	Undecided → Low
milestone:	none → ubuntu-12.04.1
Changed in gphoto2 (Ubuntu Precise):
status:	Triaged → Invalid
Changed in gphoto2 (Ubuntu):
status:	Fix Released → Invalid

Revision history for this message

Marc Deslauriers (mdeslaur) wrote on 2012-07-11:

Hi Gareth,

Thanks for the debdiff. Could you please make a few minor changes?

- Please version it as 2.4.13-1ubuntu1.1, and target "precise-proposed" instead of "precise"
- Please add this reference as the upstream patch to the Origin tag: http://gphoto.svn.sourceforge.net/viewvc/gphoto?view=revision&revision=13932
- The upstream patch does the f->files_dirt = 0 _after_ doing the delete_all_files(). Although it probably doesn't change much, could you please modify your patch to it in the same order?

Thanks!

Changed in libgphoto2 (Ubuntu Precise):
status:	Triaged → Incomplete

Revision history for this message

Gareth Williams (gareththered) wrote on 2012-07-11:

#10

debdiff Edit (2.0 KiB, text/plain)

Attached is the debdiff, altered as requested.

Revision history for this message

Michael Terry (mterry) wrote on 2012-07-12:

#11

Uploaded to precise-proposed (waiting to be approved). I made two changes:
* Added the patch to debian/patches/series (otherwise it won't actually be applied)
* Removed the whitespace-only stanza from the patch, it was just noise.

Stéphane Graber (stgraber) on 2012-07-12

Changed in libgphoto2 (Ubuntu Precise):
status:	Incomplete → In Progress
no longer affects:	gphoto2 (Ubuntu Precise)
no longer affects:	gphoto2 (Ubuntu)

Revision history for this message

Adam Conrad (adconrad) wrote on 2012-07-17: Please test proposed package

#12

Hello Gareth, or anyone else affected,

Accepted libgphoto2 into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/libgphoto2/2.4.13-1ubuntu1.1 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in libgphoto2 (Ubuntu Precise):
status:	In Progress → Fix Committed
tags:	added: verification-needed

Revision history for this message

Sebastien Bacher (seb128) wrote on 2012-07-17:

#13

I've done another upload including that fix and a backport of some new device IDs from the SVN to support a few extra hardwares if somebody from the SRU team wants to approve the new revision which includes both fixes to avoid creating an extra week delay

Gareth Williams (gareththered) on 2012-07-17

description:	updated
tags:	added: verification-done removed: verification-needed

Revision history for this message

Brian Murray (brian-murray) wrote on 2012-07-19:

#14

Hello Gareth, or anyone else affected,

Accepted libgphoto2 into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/libgphoto2/2.4.13-1ubuntu1.2 in a few hours, and then in the -proposed repository.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags:	added: hw-specific
tags:	removed: verification-done
tags:	added: verification-needed

Revision history for this message

Gareth Williams (gareththered) wrote on 2012-07-19:

#15

I can confirm that the latest version of this package (libgphoto2-2.4.13-1ubuntu1.2) verified as per the last entry in the bug description. Changing tags to verification-done.

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Sebastien Bacher (seb128) wrote on 2012-07-23:

#16

Thanks Gareth!

Revision history for this message

Scott Kitterman (kitterman) wrote on 2012-07-30: Update Released

#17

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2012-07-30:

#18

This bug was fixed in the package libgphoto2 - 2.4.13-1ubuntu1.2

---------------
libgphoto2 (2.4.13-1ubuntu1.2) precise-proposed; urgency=low

* debian/patches/svn_new_devices.patch:
- backport some new device IDs from SVN for extra hardwares support

libgphoto2 (2.4.13-1ubuntu1.1) precise-proposed; urgency=low

  * Add 85-fix-hang-during-file-download.patch to fix regression introduced
    in v2.4.13 which causes gphoto to hang while downloading from camera.
    (LP: #981062)
-- Sebastien Bacher <email address hidden> Tue, 17 Jul 2012 15:35:22 +0200