Shadow Clipping / Regressions with AWN in compiz 0.9.7.7 (built an hour ago)

Bug #979252 reported by triplesqaurednine
30
This bug affects 4 people
Affects Status Importance Assigned to Milestone
Compiz
Triaged
High
Sam Spilsbury
Compiz Core
Triaged
Undecided
Sam Spilsbury
Arch Linux
New
Undecided
Unassigned

Bug Description

I've noticed over the last few days, there has been changes to how shadows are drawn for menus. My understanding is this has a lot to do with menus looking detatched/above unity-launcher, gtk-apps, etc... For a couple days menu shadows were pretty screwed up (some shadows, some not).

Well, now there seems to be some new issues;

1. Menu shadows get clipped when to close to AWN (im sure this is true of cairo-dock too);

http://ompldr.org/vZGNjcQ/compiz-shadows-corrupt.png

I've made the background white, and highlighted the clipped shadow area (which seems to be an area that AWN uses). In the screenshot, you should notice that i am running 'winreflect' plugin (which is unsupported), however, it makes no difference where it has been disabled or removed - winreflect isn't the problem. changes in how shadows are handled is...

2. sub-menus - whenever, you select a sub-menu, than move your cursor away, shadows get clipped and it looks horrible. it basically flickers and leaves no shadow, where the sub-menu once appeared;

http://ompldr.org/vZGNjdQ/compiz-shadows-menu-corrupt.png

the AWN issue isn't super noticable, but the sub-menu issue is an eye-sore.

Related branches

Revision history for this message
triplesqaurednine (triplesquarednine) wrote :

after reading through other bug reports, it would seem this bug is the same as this one:

https://bugs.launchpad.net/compiz-core/+bug/978900

and this branch fixes the issue;

https://code.launchpad.net/~smspillaz/compiz-core/compiz-core.fix_978900

I've added myself as affected by this bu, to the other report as well.

Changed in compiz-core:
assignee: nobody → Sam Spilsbury (smspillaz)
status: New → In Progress
milestone: none → 0.9.7.8
Revision history for this message
triplesqaurednine (triplesquarednine) wrote :

Thanks Daniel.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Fix committed into lp:compiz-core at revision 3094

Changed in compiz-core:
status: In Progress → Fix Committed
Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Fix released in Compiz Core 0.9.7.8.

Revision history for this message
Daniel van Vugt (vanvugt) wrote :

Actually, I just tested AWN for the first time and this bug is not fixed at all.

summary: - Shadow Clipping / Regressions compiz 0.9.7.7 (built an hour ago)
+ Shadow Clipping / Regressions with compiz 0.9.7.7 (built an hour ago)
summary: - Shadow Clipping / Regressions with compiz 0.9.7.7 (built an hour ago)
+ Shadow Clipping / Regressions with AWN in compiz 0.9.7.7 (built an hour
+ ago)
Revision history for this message
triplesqaurednine (triplesquarednine) wrote :

Hey Daniel,

I also just tested this, and it's not fixed. I must have forgotten about this, and never enabled animations for menus until now. So yes, this bug still exists.

...and since you have AWN installed, could you see if you can verify this bug;

https://bugs.launchpad.net/compiz-core/+bug/986260

Changed in compiz:
assignee: nobody → Sam Spilsbury (smspillaz)
status: New → Triaged
Changed in compiz:
milestone: none → 0.9.8.0
no longer affects: compiz-core/0.9.7
no longer affects: compiz-core/0.9.8
Changed in compiz:
milestone: 0.9.8.0 → 0.9.8.1
Changed in compiz:
milestone: 0.9.8.2 → 0.9.8.4
Changed in compiz:
milestone: 0.9.8.4 → 0.9.9.0
Changed in compiz:
milestone: 0.9.9.0 → 0.9.9.2
Changed in compiz:
milestone: 0.9.9.2 → 0.9.10.0
MC Return (mc-return)
Changed in compiz:
importance: Undecided → High
Changed in compiz:
milestone: 0.9.10.0 → 0.9.10.2
MC Return (mc-return)
Changed in compiz:
milestone: 0.9.10.2 → 0.9.11.0
Revision history for this message
dimx (dimx) wrote :

I can confirm this bug affecting Cairo-dock too on 2 systems
(arch,slackware - either with proprietary or free drivers).
versions 0.9.9 through 0.9.11-bzr

Please update the title accordingly to reflect that it affects Cairo-dock as well as AWN.

Cairo-dock seems to have a larger window than what is drawn, due to a big part of it being transparrent.
Since it is (correctly) treated as a dock by compiz, it is always above other windows.

Now, when the menu of another window is drawn, it is drawn correctly above the invisible part of the dock, but for some reason the shadows are drawn beneath it!!! That must be the reason of clipping occurrence.

What is strange, that even Cairo-dock's own menu appears to clipped (when in vertical mode it becomes very clearly visible).

Some screenshots of menus' shadow clippings:
http://en.zimagez.com/zimage/screenshot-04022014-cropped.php
http://en.zimagez.com/zimage/compizbug2.php

Any help would be appreciated.

Revision history for this message
p (pino-silvaggio) wrote :

Ok, so after years still no fix.

Since I provide a compiz-0.9.12.x build for OpenSUSE through the build service I finally took a look:

plugins/decor/src/decor.cpp

line 3038 -> mMenusClipGroup (CompMatch ("type=Dock | type=DropdownMenu | type=PopupMenu"))

I don't know why "DropdownMenu" and "PopupMenu" should be clipped... I removed those entry and now everything is peachy.

I wonder why it is hardcoded, could be defaults for some plugin param...

Revision history for this message
Sam Spilsbury (smspillaz) wrote : Re: [Bug 979252] Re: Shadow Clipping / Regressions with AWN in compiz 0.9.7.7 (built an hour ago)

Hi,

On Sun, Jun 7, 2015 at 4:07 AM, p <email address hidden> wrote:

> Ok, so after years still no fix.
>
> Since I provide a compiz-0.9.12.x build for OpenSUSE through the build
> service I finally took a look:
>
> plugins/decor/src/decor.cpp
>
> line 3038 -> mMenusClipGroup (CompMatch ("type=Dock | type=DropdownMenu
> | type=PopupMenu"))
>
> I don't know why "DropdownMenu" and "PopupMenu" should be clipped... I
> removed those entry and now everything is peachy.
>
> I wonder why it is hardcoded, could be defaults for some plugin param...
>

Thats to provide shadow clipping against adjacent menus, so that you don't
get spillover shadows on to those menus. The proper fix will probably be to
make the clipping code look at the input shape region as well, although I
thought it already did that.

>
> --
> You received this bug notification because you are a bug assignee.
> https://bugs.launchpad.net/bugs/979252
>
> Title:
> Shadow Clipping / Regressions with AWN in compiz 0.9.7.7 (built an
> hour ago)
>
> Status in Compiz:
> Triaged
> Status in Compiz Core:
> Triaged
> Status in Arch Linux:
> New
>
> Bug description:
> I've noticed over the last few days, there has been changes to how
> shadows are drawn for menus. My understanding is this has a lot to do
> with menus looking detatched/above unity-launcher, gtk-apps, etc...
> For a couple days menu shadows were pretty screwed up (some shadows,
> some not).
>
> Well, now there seems to be some new issues;
>
> 1. Menu shadows get clipped when to close to AWN (im sure this is true
> of cairo-dock too);
>
> http://ompldr.org/vZGNjcQ/compiz-shadows-corrupt.png
>
> I've made the background white, and highlighted the clipped shadow
> area (which seems to be an area that AWN uses). In the screenshot, you
> should notice that i am running 'winreflect' plugin (which is
> unsupported), however, it makes no difference where it has been
> disabled or removed - winreflect isn't the problem. changes in how
> shadows are handled is...
>
> 2. sub-menus - whenever, you select a sub-menu, than move your cursor
> away, shadows get clipped and it looks horrible. it basically flickers
> and leaves no shadow, where the sub-menu once appeared;
>
> http://ompldr.org/vZGNjdQ/compiz-shadows-menu-corrupt.png
>
> the AWN issue isn't super noticable, but the sub-menu issue is an eye-
> sore.
>
> To manage notifications about this bug go to:
> https://bugs.launchpad.net/compiz/+bug/979252/+subscriptions
>

--
Sam Spilsbury

Revision history for this message
p (pino-silvaggio) wrote :

Yes I have noticed. But it's really a minor issue and doesn't look that bad.

It's a trade-off and because I use cairo-dock I can tolerate the shadows spillover better than ugly clipping...

Of course I hope for a proper fix.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.