Compiz Animations Plugin

Menu bar - Shadows are not clipped until animations are finished

Bug #976469 reported by Sam Spilsbury on 2012-04-08

This bug affects 1 person

	Status	Importance	Assigned to	Milestone
Ayatana Design	Fix Released	Medium	John Lea
Compiz Animations Plugin	Fix Released	Medium	Sam Spilsbury
Compiz Main Plugins	Fix Released	Medium	Sam Spilsbury	Compiz Main Plugins 0.9.7.2
compiz-plugins-main (Ubuntu)	Fix Released	Undecided	Unassigned

Bug Description

See: https://bugs.launchpad.net/compiz-core/+bug/659816/comments/10

"and when you switch between menuitems in the panel you see the shadow appearing on top and then being cut"

The problem is that the animation plugin sets PAINT_WINDOW_TRANSFORMED_MASK even when it doesn't really need it. (Shadow clipping is disabled on transformed windows)

Tags:

Related branches

lp:~smspillaz/compiz-animation-plugin/compiz-animation-plugin.fix_976469

Merged into lp:compiz-animation-plugin at revision 396

Daniel van Vugt: Approve on 2012-04-10

lp:compiz-animation-plugin

lp:compiz-plugins-main

lp:~compiz/compcomm-plugins-main/ubuntu

lp:~smspillaz/compiz-animation-plugin/compiz-animation-plugin.fix_976469_abi_safe

Rejected for merging into lp:compiz-animation-plugin

Sam Spilsbury: Disapprove on 2012-04-16

Daniel van Vugt: Needs Fixing on 2012-04-16

lp:ubuntu/precise/compiz-plugins-main

Sam Spilsbury (smspillaz) on 2012-04-08

Changed in compiz-animation-plugin:
status:	New → In Progress
importance:	Undecided → Medium
assignee:	nobody → Sam Spilsbury (smspillaz)
Changed in compiz-plugins-main:
status:	New → In Progress
importance:	Undecided → Medium
assignee:	nobody → Sam Spilsbury (smspillaz)
milestone:	none → 0.9.7.2

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2012-04-10:

Fix committed into lp:compiz-animation-plugin at revision 396

Changed in compiz-animation-plugin:
status:	In Progress → Fix Committed
Changed in compiz-plugins-main:
status:	In Progress → Fix Committed

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2012-04-10:

Fix committed into lp:compiz-plugins-main at revision 26

Changed in compiz-plugins-main (Ubuntu):
status:	New → Confirmed

Revision history for this message

Andrea Cimitan (cimi) wrote on 2012-04-10:

not fixed for me in unity staging PPA

Revision history for this message

Andrea Cimitan (cimi) wrote on 2012-04-10:

Video of the issue Edit (290.0 KiB, video/ogg)

Revision history for this message

Andrea Cimitan (cimi) wrote on 2012-04-10:

Video with radiance Edit (235.1 KiB, video/ogg)

John Lea (johnlea) on 2012-04-10

summary:	- Shadows are not clipped until animations are finished + Menu bar - Shadows are not clipped until animations are finished
tags:	added: udp
Changed in ayatana-design:
assignee:	nobody → John Lea (johnlea)
importance:	Undecided → Medium
status:	New → Fix Committed

Revision history for this message

Andrea Cimitan (cimi) wrote on 2012-04-10:

video at 50fps Edit (285.7 KiB, video/ogg)

Still seeing it live live is more visible, recording skips frames, but you can see sometimes the shadow even not being clipped.
Daniel, opinions?

If I remember I noticed this before the clipping code went in, it's just more visible now.

Revision history for this message

Andrea Cimitan (cimi) wrote on 2012-04-10:

Maybe extending the clip match code mMenusClipGroup (CompMatch ("type=Dock | type=DropdownMenu | type=PopupMenu")) with a unity panel case?

I have the feeling the unity menus lose their type (or something happens) when you switch between them. It could be that unity tells compiz about their type slowly

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2012-04-11:

Cimi, I think this bug is mostly a duplicate of bug 659816, which is _not_ fixed and I commented on yesterday.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2012-04-12:

This bug was fixed in the package compiz-plugins-main - 1:0.9.7.0~bzr19-0ubuntu10

---------------
compiz-plugins-main (1:0.9.7.0~bzr19-0ubuntu10) precise; urgency=low

[ Sam Spilsbury ]
* debian/patches/fix_963767.patch : fix LP: #963767, scale correctly

  [ Didier Roche ]
  * debian/patches/ubuntu_config.patch:
    Fix typos in animation.xml.in causing mismatched animations of menus and
    tooltips (LP: #977743)
  * debian/patches/fix_976469.patch:
    - Shadows are not clipped until animations are finished (LP: #976469)
  * debian/patches/fix_940603.patch:
    - white box randomly shows up at top left corner blocking applications from
      using stuff under it (LP: #940603)

  [ Oliver Grawert ]
  * update GLES2 patch for latest changes.
  * thanks to Łukasz 'sil2100' Zemczak <email address hidden> for
    merging the packaging changes into the right branches.
-- Didier Roche <email address hidden> Thu, 12 Apr 2012 09:19:07 +0200

Changed in compiz-plugins-main (Ubuntu):
status:	Confirmed → Fix Released

Revision history for this message

Daniel van Vugt (vanvugt) wrote on 2012-04-26:

#10

Fix released in Compiz Main Plugins 0.9.7.2

Changed in compiz-plugins-main:
status:	Fix Committed → Fix Released

John Lea (johnlea) on 2012-04-27

Changed in compiz-animation-plugin:
status:	Fix Committed → Fix Released
Changed in ayatana-design:
status:	Fix Committed → Fix Released
tags:	added: reviewedbydesignp removed: udp

Report a bug

This report contains Public information

Everyone can see this information.

You are

Subscribing...

Edit bug mail

Other bug subscribers

Bug attachments

Add attachment

Remote bug watches

Bug watches keep track of this bug in other bug trackers.