openstack-common

auto generate AUTHORS for packaging

Bug #976267 reported by Bhuvan Arumugam
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
OpenStack Compute (nova)
Fix Released
Undecided
Bhuvan Arumugam
OpenStack Dashboard (Horizon)
Fix Released
Wishlist
Bhuvan Arumugam
OpenStack Object Storage (swift)
Fix Released
Wishlist
Bhuvan Arumugam
openstack-common
Fix Released
Medium
Bhuvan Arumugam
openstack-common 2012.2 "folsom"

Bug Description

As discussed in bug 920757, the check-ins for all projects are gated using CLA sign. It's not necessary to enforce an entry in AUTHORS file. The file should be auto-generated when we package using "python setup.py sdist" command. The .mailmap file, if exists, should be honored. This is applicable for all projects, swift, keystone, nova and glance.

Once this is resolved, we could remove the test, test_authors.py that check for an entry in AUTHORS file.

Bhuvan Arumugam (bhuvan)
Changed in openstack-ci:
assignee: nobody → Bhuvaneswaran A (bhuvan)
Revision history for this message
Bhuvan Arumugam (bhuvan) wrote :

For the record, posted a patch for review. With this patch, the AUTHORS file is auto-generated when the package is created:
  $ python setup.py sdist

I've proposed the patch for keystone component. Once it's merged, i'll implement similar solution for other components:
  https://review.openstack.org/6421

Revision history for this message
Bhuvan Arumugam (bhuvan) wrote :

Proposed a patch to auto generate AUTHORS file in glance.
  https://review.openstack.org/6698

Revision history for this message
Bhuvan Arumugam (bhuvan) wrote :

Proposed a patch to auto generate AUTHORS file in nova.
  https://review.openstack.org/6699

Revision history for this message
Monty Taylor (mordred) wrote :

Hey!

Could we add a new requirement on you here?

(also, updating the stuff in openstack-common to address termie's questions about . at end of sentence)

Swift has people in the AUTHORS file who existed before VCS was around. So could generate_authors look for an optional file called AUTHORS.in, and if it exists, append it to the end of the generated AUTHORS?

Revision history for this message
Bhuvan Arumugam (bhuvan) wrote :

Sure, i'll incorporate these suggestion and post a new patch.

Revision history for this message
Bhuvan Arumugam (bhuvan) wrote :

Monty, incorporated the suggestion in openstack-common/openstack/common/setup.py library. Once it's merged, i'll extend it to keystone and other components.
  https://review.openstack.org/6878

Revision history for this message
Bhuvan Arumugam (bhuvan) wrote :

Not sure, why the status was not updated from jenkins, automatically.

Anyway, the patch was merged to openstack-common/openstack/common/setup.py. I'll extend it to other components, once this patch goes in:
https://review.openstack.org/6421

Revision history for this message
Bhuvan Arumugam (bhuvan) wrote :

The patch to auto generate AUTHORS for keystone has been merged. The patch also include:
  a) change related to appending AUTHORS.in file
  b) remove test_authors test case.

https://review.openstack.org/6421

Revision history for this message
Bhuvan Arumugam (bhuvan) wrote :

The patch to auto generate AUTHORS for glance has been merged.
  https://review.openstack.org/#/c/6698/

Posted a patch for review python-openstackclient.
  https://review.openstack.org/#/c/7003

Remaining projects to handle:
  1) swift
  2) horizon
  3) python-keystoneclient
  4) python-novaclient
  5) python-glanceclient

I'll submit patches to auto generate this file. I'll remove associated test case, if present.

If i had missed any projects, it's because, the AUTHORS file is not stored in git.

Bhuvan Arumugam (bhuvan)
affects: openstack-ci → openstack-common
Mark McLoughlin (markmc)
Changed in openstack-common:
status: New → Fix Committed
importance: Undecided → Medium
milestone: none → folsom-1
Revision history for this message
Bhuvan Arumugam (bhuvan) wrote :

Mark, the patch for nova is still in review state:
  https://review.openstack.org/#/c/6699/

After this patch, I'm working on patch for few more projects, listed in #9. Leaving it as "In Progress".

Changed in openstack-common:
status: Fix Committed → In Progress
Mark McLoughlin (markmc)
Changed in openstack-common:
status: In Progress → Fix Committed
Revision history for this message
Bhuvan Arumugam (bhuvan) wrote :

Mark, ?? Can you please explain why you set it as "Fix committed" even though the patch should go in few more projects?

Changed in nova:
assignee: nobody → Bhuvaneswaran A (bhuvan)
Revision history for this message
Bhuvan Arumugam (bhuvan) wrote :

Mark, nevermind. I got it.

OpenStack Infra (hudson-openstack)
Changed in nova:
status: New → In Progress
Gabriel Hurley (gabriel-hurley)
Changed in horizon:
importance: Undecided → Wishlist
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to horizon (master)

Fix proposed to branch: master
Review: https://review.openstack.org/7600

Changed in horizon:
assignee: nobody → Bhuvaneswaran A (bhuvan)
status: Confirmed → In Progress
John Dickinson (notmyname)
Changed in swift:
importance: Undecided → Wishlist
John Dickinson (notmyname)
Changed in swift:
status: New → Confirmed
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to swift (master)

Fix proposed to branch: master
Review: https://review.openstack.org/8377

Changed in swift:
assignee: nobody → Bhuvaneswaran A (bhuvan)
status: Confirmed → In Progress
Gabriel Hurley (gabriel-hurley)
Changed in horizon:
status: In Progress → Fix Released
Mark McLoughlin (markmc)
Changed in openstack-common:
milestone: folsom-1 → 2012.2
status: Fix Committed → Fix Released
Sean Dague (sdague)
Changed in swift:
status: In Progress → Fix Released
Changed in nova:
status: In Progress → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.