Ubuntu
cmake package

Deb's created with cpack contain corrupted content tarball.

Bug #972419 reported by Philip Marc Schwartz
52
This bug affects 8 people
Affects Status Importance Assigned to Milestone
cmake (Ubuntu)
Fix Released
High
Unassigned
Precise
Fix Released
High
Brian Murray

Bug Description

I have tried to build 3 different projects that use cmake + cpack to create deb files. All packages created with the repository version of cmake contain corrupted content tarballs.

Downloading of 2.8.7 source from the cmake.org website and building it for use results in valid working packages being generated.

ProblemType: Bug
DistroRelease: Ubuntu 12.04
Package: cmake 2.8.7-0ubuntu4
ProcVersionSignature: User Name 3.2.0-21.34-virtual 3.2.13
Uname: Linux 3.2.0-21-virtual x86_64
ApportVersion: 2.0-0ubuntu2
Architecture: amd64
Date: Tue Apr 3 13:00:42 2012
Ec2AMI: ami-00000034
Ec2AMIManifest: FIXME
Ec2AvailabilityZone: nova
Ec2InstanceType: m2.medium
Ec2Kernel: unavailable
Ec2Ramdisk: unavailable
ProcEnviron:
 TERM=xterm
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: cmake
UpgradeStatus: No upgrade log present (probably fresh install)

[IMPACT]
All packages and tar files built with libarchive from files which contain file flags are corrupted by the compression used. This affects all DEB packages, and possibly other package formats too. Bug has been fixed upstream

[TESTCASE]
Download and extract archive cpack_test_case.tar.gz from comment #7
This contains a sample CMakeLists.txt file for the CMake project, a dummy C++ file (DistanceBetweenPoints.cxx) and a dummy file directory with many files (tmp). When extracted, the tmp dir should have the 'I' file flag set when running lsattr:

lsattr cpack_test_case/tmp

If the 'I' flag is not present on this directory, more dummy files should be created in this directory, until the directory

To test the packaging:

# cd build

# cmake ../

# make package

# sudo dpkg -i DistanceBetweenPoints.deb

The package currently does not install, with error message:

___
Selecting previously unselected package distancebetweenpoints.
(Reading database ... 381484 files and directories currently installed.)
Unpacking distancebetweenpoints (from DistanceBetweenPoints-0.1.1-Linux.deb) ...

dpkg: error processing DistanceBetweenPoints-0.1.1-Linux.deb (--install):
 corrupted filesystem tarfile - corrupted package archive

Errors were encountered while processing:
 DistanceBetweenPoints-0.1.1-Linux.deb
____

With the patch applied, this package should install fine.

[REGRESSION POTENTIAL]

There is little risk of regression, packages/tar files created with CMake could not be unpacked regardless, so this fix will not regress any behaviour with these files.

[OTHER]

Discussion of this bug, and another test case can be found:

http://public.kitware.com/pipermail/cmake-developers/2012-June/004197.html

See original description

Related branches

lp:~dynamite-a-d/ubuntu/precise/cmake/fix-for-972419
On hold for merging into lp:ubuntu/precise/cmake
Brian Murray: Approve
Ubuntu branches: Pending requested
Diff: 43 lines (+23/-0)
3 files modified
debian/changelog (+7/-0)
debian/patches/99-cpack-corrupted-tarball-debs-fix.patch (+15/-0)
debian/patches/series (+1/-0)
lp:ubuntu/precise-proposed/cmake
Revision history for this message
Philip Marc Schwartz (philip-schwartz) wrote :
Revision history for this message
Launchpad Janitor (janitor) wrote :

Status changed to 'Confirmed' because the bug affects multiple users.

Changed in cmake (Ubuntu):
status: New → Confirmed
Revision history for this message
David Dunsmore (dynamite-a-d) wrote :

This bug has been identified as an issue with libarchive12 and CMake. For a disucssion, please see:
http://comments.gmane.org/gmane.comp.programming.tools.cmake.devel/3837

The required fix for this has been changed upstream, in commit:
http://cmake.org/gitweb?p=cmake.git;a=commitdiff;h=a34015d3

Is there any chance this change can be patched to this package, and updated, so that this bug is solved? It would be a great help.

Thanks

Revision history for this message
Brian Murray (brian-murray) wrote :

This is already fixed in Quantal which will become Ubuntu 12.10.

http://bazaar.launchpad.net/~ubuntu-branches/ubuntu/quantal/cmake/quantal/view/head:/Source/cmArchiveWrite.cxx#L242

Changed in cmake (Ubuntu Precise):
status: New → Triaged
importance: Undecided → High
Changed in cmake (Ubuntu):
status: Confirmed → Fix Released
importance: Undecided → High
Revision history for this message
Brian Murray (brian-murray) wrote :

This bug needs some additional information before it can be uploaded to precise-proposed. Please see https://wiki.ubuntu.com/StableReleaseUpdates#Procedure for the details.

David Dunsmore (dynamite-a-d)
description: updated
Revision history for this message
David Dunsmore (dynamite-a-d) wrote :
David Dunsmore (dynamite-a-d)
description: updated
Revision history for this message
Brian Murray (brian-murray) wrote :

I was unable to get the testcase to work as the tmp dir never had the I flag set.

Revision history for this message
David Dunsmore (dynamite-a-d) wrote :

The I flag is set by the kernel when the filesystem is using a hash tree to store the directory index (http://en.wikipedia.org/wiki/Htree). It only happens when using an ext4 filesystem, or ext3 with the dir_index mount option set, but I believe if you continue to add new files to the tmp directory it will eventually use a hash tree to index the directory, at which point the I flag will be set and cpack will fail to create a valid debian package

Brian Murray (brian-murray)
Changed in cmake (Ubuntu Precise):
status: Triaged → In Progress
assignee: nobody → Brian Murray (brian-murray)
Revision history for this message
Scott Kitterman (kitterman) wrote : Please test proposed package

Hello Philip, or anyone else affected,

Accepted into quantal-proposed. The package will build now and be available in a few hours in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

tags: added: verification-needed
Revision history for this message
David Dunsmore (dynamite-a-d) wrote :

Tested the package in -proposed, fixes this bug, no regressions noted

tags: added: verification-done
removed: verification-needed
Brian Murray (brian-murray)
Changed in cmake (Ubuntu Precise):
status: In Progress → Fix Committed
Revision history for this message
Scott Kitterman (kitterman) wrote : Update Released

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cmake - 2.8.7-0ubuntu5

---------------
cmake (2.8.7-0ubuntu5) precise-proposed; urgency=low

  * Fix corrupted tarballs when using DEB generator in CPack.
    (LP: #972419)
 -- David Dunsmore <email address hidden> Thu, 06 Sep 2012 14:36:50 +0100

Changed in cmake (Ubuntu Precise):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Duplicates of this bug

Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.