Windows keyring uses twisted deferToThreads even when no reactor is installed
Bug #969159 reported by
Alejandro J. Cura
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| Ubuntu Single Sign On Client | Status tracked in Trunk | |||||
| Stable-3-0 |
Fix Released
|
Undecided
|
Unassigned | |||
| Trunk |
Fix Released
|
High
|
Unassigned | |||
| ubuntu-sso-client (Ubuntu) |
Invalid
|
High
|
Alejandro J. Cura | |||
Bug Description
The proxy tunnel in windows is using the keyring, which is trying to use deferToThread from twisted even when no reactor is installed or needed. This obviously won't work at all.
Two options to fix this:
* make the tunnel use qt4reactor on windows
* make the keyring use an alternate to deferToThread
Related branches
lp:~alecu/ubuntu-sso-client/qt-defer-to-thread
- Roberto Alsina (community): Approve
- Eric Casteleijn (community): Approve
- Diff: 0 lines
lp:~nataliabidart/ubuntu-sso-client/stable-3-0-update-2.99.92
- Alejandro J. Cura (community): Approve
-
Diff: 548 lines (+341/-13)12 files modifieddata/qt/stylesheet.qss (+4/-1)
ubuntu_sso/keyring/windows.py (+1/-1)
ubuntu_sso/networkstate/tests/test_windows.py (+4/-7)
ubuntu_sso/networkstate/windows.py (+2/-2)
ubuntu_sso/utils/runner/qt.py (+7/-0)
ubuntu_sso/utils/runner/tests/test_qt.py (+19/-0)
ubuntu_sso/utils/tests/test_windows.py (+65/-0)
ubuntu_sso/utils/webclient/gsettings.py (+8/-1)
ubuntu_sso/utils/webclient/qtnetwork.py (+8/-1)
ubuntu_sso/utils/webclient/tests/test_gsettings.py (+23/-0)
ubuntu_sso/utils/webclient/tests/test_qtnetwork.py (+157/-0)
ubuntu_sso/utils/windows.py (+43/-0)
| Changed in ubuntu-sso-client (Ubuntu): | |
| status: | In Progress → Invalid |
| status: | Invalid → In Progress |
| status: | In Progress → Invalid |
| Changed in ubuntu-sso-client: | |
| status: | New → In Progress |
| importance: | Undecided → High |
| Changed in ubuntu-sso-client: | |
| status: | In Progress → Fix Committed |
To post a comment you must log in.
