"/ping" with no arguments CTCP PINGs the channel

Bug #96758 reported by Lorenzo J. Lucchini
6
Affects Status Importance Assigned to Milestone
irssi (Ubuntu)
Fix Released
Low
Unassigned

Bug Description

Binary package hint: irssi-text

The "/ping" command, on most IRC clients of my knowledge, sends a PING command to the IRC server.

On irssi, "/ping <channel/nickname>" sends a CTCP PING to <channel/nickname>, and even "/ping" without any arguments sends one to the current channel.

Pinging an entire large channel (such as the official Ubuntu support channel) is often not tolerated, and getting hundreds of CTCP PING replies from other users is likely to deny service to the sender's client.

I believe that a more appropriate action for "/ping" would be to send PING to the server, or at least to refuse to work without an explicit channel/nickname argument.

Related branches

Revision history for this message
Emilio Pozuelo Monfort (pochu) wrote :

Confirmed in 0.8.12

Changed in irssi:
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Emilio Pozuelo Monfort (pochu) wrote :
Revision history for this message
Emilio Pozuelo Monfort (pochu) wrote :

Fixed upstream, to be released with the next irssi release.

Changed in irssi:
assignee: nobody → pochu
status: Confirmed → Fix Committed
Revision history for this message
Pedro Fragoso (ember) wrote :
Changed in irssi:
assignee: pochu → ubuntu-universe-sponsors
Changed in irssi:
assignee: ubuntu-universe-sponsors → nobody
status: Fix Committed → Triaged
Revision history for this message
Daniel Holbach (dholbach) wrote :

Sorry, bug spam necessary because of bug 176085.

This bug has a patch attached, which needs review and sponsoring.

Revision history for this message
Colin Watson (cjwatson) wrote :

I corrected "now allow" to "not allow" in the dpatch header, and edited the changelog to actually describe the patch rather than just mentioning its existence and to fix the bug closing syntax. Please take account of these in future uploads. Otherwise, uploaded, thanks!

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package irssi - 0.8.12-2ubuntu2

---------------
irssi (0.8.12-2ubuntu2) hardy; urgency=low

  * debian/patches/10ping_ctcp: prevent /ping with no arguments from sending
    CTCP PING to a channel (backported from SVN, LP: #96758).

 -- Pedro Fragoso <email address hidden> Tue, 04 Dec 2007 19:40:59 +0000

Changed in irssi:
status: Triaged → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.