Glance

Cannot specify a version to 'glance-manage version_control'

Bug #966242 reported by Mark McLoughlin
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Glance
Fix Released
Medium
Mark McLoughlin
Glance 2012.1 "essex"

Bug Description

'glance-manage version_control' takes an existing unversioned database and associations it with a migration version.

However, you can't actually specify a migration version, so it defaults to zero. This only makes sense for a completely empty database.

See bug #966241 for why you might a unversioned DB in the first place.

See original description
Mark McLoughlin (markmc)
Changed in glance:
assignee: nobody → Mark McLoughlin (markmc)
description: updated
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (master)

Fix proposed to branch: master
Review: https://review.openstack.org/5862

Changed in glance:
status: New → In Progress
Brian Waldon (bcwaldon)
tags: added: essex-rc-potential
Changed in glance:
importance: Undecided → Medium
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (master)

Reviewed: https://review.openstack.org/5862
Committed: http://github.com/openstack/glance/commit/da66de06763dd872f139491930cf1deb6a723b06
Submitter: Jenkins
Branch: master

commit da66de06763dd872f139491930cf1deb6a723b06
Author: Mark McLoughlin <email address hidden>
Date: Tue Mar 27 12:23:47 2012 +0100

    Allow specifying the current version in 'glance-manage version_control'

    Fixes bug #966242

    The version_control command is a bit useless since you can't actually
    specify what version to use and it defaults to version=0.

    Allow the user to specify a version:

      $> glance-manage version_control 9 # set the diablo version

    and default to the latest version if none is specified.

    Also, allow db_sync to be supplied a version for the case where we're
    upgrading an unversioned DB.

    Finally, re-work the argument handling in glance-manage to more easily
    handle optional args.

    The tests are extended to test using db_sync for upgrades and to test
    placing an existing database under version control.

    Change-Id: I231dc710554198bfd1fdcb82c3c3768963f64bd8

Changed in glance:
status: In Progress → Fix Committed
Brian Waldon (bcwaldon)
Changed in glance:
milestone: none → essex-rc2
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (milestone-proposed)

Fix proposed to branch: milestone-proposed
Review: https://review.openstack.org/5980

Thierry Carrez (ttx)
tags: removed: essex-rc-potential
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (milestone-proposed)

Reviewed: https://review.openstack.org/5980
Committed: http://github.com/openstack/glance/commit/1e708f423c5c8a3ac2c2905971a04e47bd484c88
Submitter: Jenkins
Branch: milestone-proposed

commit 1e708f423c5c8a3ac2c2905971a04e47bd484c88
Author: Mark McLoughlin <email address hidden>
Date: Tue Mar 27 12:23:47 2012 +0100

    Allow specifying the current version in 'glance-manage version_control'

    Fixes bug #966242

    The version_control command is a bit useless since you can't actually
    specify what version to use and it defaults to version=0.

    Allow the user to specify a version:

      $> glance-manage version_control 9 # set the diablo version

    and default to the latest version if none is specified.

    Also, allow db_sync to be supplied a version for the case where we're
    upgrading an unversioned DB.

    Finally, re-work the argument handling in glance-manage to more easily
    handle optional args.

    The tests are extended to test using db_sync for upgrades and to test
    placing an existing database under version control.

    Change-Id: I231dc710554198bfd1fdcb82c3c3768963f64bd8

Changed in glance:
status: Fix Committed → Fix Released
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix proposed to glance (stable/diablo)

Fix proposed to branch: stable/diablo
Review: https://review.openstack.org/6077

Thierry Carrez (ttx)
Changed in glance:
milestone: essex-rc2 → 2012.1
Revision history for this message
OpenStack Infra (hudson-openstack) wrote : Fix merged to glance (stable/diablo)

Reviewed: https://review.openstack.org/6077
Committed: http://github.com/openstack/glance/commit/2f9eba10e05207adc92619084755ad204fd1f05d
Submitter: Jenkins
Branch: stable/diablo

commit 2f9eba10e05207adc92619084755ad204fd1f05d
Author: Mark McLoughlin <email address hidden>
Date: Tue Mar 27 12:23:47 2012 +0100

    Allow specifying the current version in 'glance-manage version_control'

    Fixes bug #966242

    The version_control command is a bit useless since you can't actually
    specify what version to use and it defaults to version=0.

    Allow the user to specify a version:

      $> glance-manage version_control 9 # set the diablo version

    and default to the latest version if none is specified.

    Also, allow db_sync to be supplied a version for the case where we're
    upgrading an unversioned DB.

    Finally, re-work the argument handling in glance-manage to more easily
    handle optional args.

    The tests are extended to test using db_sync for upgrades and to test
    placing an existing database under version control.

    Change-Id: I231dc710554198bfd1fdcb82c3c3768963f64bd8

tags: added: in-stable-diablo
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.