binary backend always claims to work if devportal-metadata.json is present
Bug #954563 reported by
James Westby
This bug affects 1 person
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
pkgme-devportal |
Fix Released
|
High
|
James Westby |
Bug Description
A common failure mode of pkgme-service is "NoBinariesFound" which we know
to mean that pkgme-binary couldn't handle the submission, but it's not immediately
obvious.
If the binary backend is going to fail if there are no binaries, then it could check
this in the "want" script, rather than only looking for devportal-
That would mean that where pkgme-service couldn't handle the submission the
error would be "No suitable backend", which is much more obvious (and could even be
caught and transformed in to something even more explicit by pkgme-service
with no layering violation.)
Thanks,
James
Related branches
lp:~james-w/pkgme-devportal/binary-want-only-binaries
- Jonathan Lange: Approve
-
Diff: 103 lines (+43/-6)3 files modifieddevportalbinary/binary.py (+2/-1)
devportalbinary/testing.py (+26/-0)
devportalbinary/tests/test_binary.py (+15/-5)
Changed in pkgme-binary: | |
status: | New → Triaged |
importance: | Undecided → High |
Changed in pkgme-binary: | |
status: | Triaged → In Progress |
assignee: | nobody → James Westby (james-w) |
Changed in pkgme-binary: | |
status: | In Progress → Fix Committed |
Changed in pkgme-devportal: | |
status: | Fix Committed → Fix Released |
To post a comment you must log in.