UI configuration: server hostname is not sanitized
Bug #954507 reported by
David Britton
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Landscape Client |
Fix Released
|
Medium
|
Geoff Teale | ||
Bug Description
If I put in garbage in the server hostname, it just takes it. Which I guess is OK, the config seems pretty robust underneath. But it even takes things that are common user errors like whitespace before and after (cut-and-paste error).
We should probably at the minium trim the result of what is in this field.
Related branches
lp:~tealeg/landscape-client/sanitise-hostname
- Chad Smith: Approve
- Mike Milner (community): Approve
-
Diff: 503 lines (+258/-12) (has conflicts)9 files modifiedlandscape/ui/view/configuration.py (+77/-2)
landscape/ui/view/tests/test_configuration.py (+56/-0)
landscape/ui/view/ui/landscape-client-settings.glade (+1/-1)
man/landscape-client.1 (+1/-1)
man/landscape-config.1 (+1/-1)
man/landscape-message.1 (+1/-1)
po/fr.po (+83/-6)
po/landscape-client.pot (+36/-0)
setup.cfg (+2/-0)
| Changed in landscape-client: | |
| assignee: | nobody → Mike Milner (milner) |
| status: | New → In Progress |
| Changed in landscape-client: | |
| status: | In Progress → New |
| assignee: | Mike Milner (milner) → nobody |
| Changed in landscape-client: | |
| status: | New → In Progress |
| assignee: | nobody → Geoff Teale (tealeg) |
| Changed in landscape-client: | |
| status: | In Progress → Fix Committed |
| Changed in landscape-client: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
