IE users cannot use inline-pickers or find html forms to change their data
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Critical
|
Curtis Hovey | ||
Bug Description
The inline picker code used to render dynamic widgets in the page has this amateur fragment of code in the script block:
if (Y.UA.ie) {
return;
}
The code supports script and no-script situations, but the script will not execute for IE users. The link to the html form is never rendered for the user. The inline-picker was retrofitted to many pages. The blueprint page uses them exclusively.
Why is this? What does ALL versions of IE not support? Why is there a noscript block...why not use plain HTML and add features to it when the browser supports the feature?
Related branches
- j.c.sackett (community): Approve
- Richard Harding (community): Approve (code*)
-
Diff: 646 lines (+245/-134)17 files modifiedlib/lp/app/doc/lazr-js-widgets.txt (+13/-16)
lib/lp/app/javascript/autocomplete/autocomplete.js (+0/-7)
lib/lp/app/javascript/picker/tests/test_personpicker.html (+4/-4)
lib/lp/app/javascript/picker/tests/test_picker_patcher.html (+4/-4)
lib/lp/app/javascript/tests/test_multicheckboxwidget.html (+3/-4)
lib/lp/app/templates/inline-multicheckbox-widget.pt (+10/-9)
lib/lp/app/templates/inline-picker.pt (+15/-19)
lib/lp/bugs/javascript/bugtask_index.js (+1/-1)
lib/lp/bugs/javascript/official_bug_tags.js (+11/-8)
lib/lp/bugs/javascript/tests/test_official_bug_tags.html (+133/-0)
lib/lp/bugs/javascript/tests/test_official_bug_tags.js (+49/-0)
lib/lp/bugs/templates/bugtarget-macros-filebug.pt (+1/-3)
lib/lp/bugs/templates/official-bug-target-manage-tags.pt (+1/-3)
lib/lp/bugs/tests/testfiles/sourceforge-project-fronobulator.html (+0/-45)
lib/lp/bugs/tests/testfiles/sourceforge-tracker-5570.html (+0/-3)
lib/lp/registry/stories/project/xx-project-edit.txt (+0/-3)
lib/lp/registry/templates/product-index.pt (+0/-5)
- j.c.sackett (community): Approve
-
Diff: 820 lines (+499/-92)16 files modifiedlib/lp/code/javascript/requestbuild_overlay.js (+15/-0)
lib/lp/code/javascript/tests/test_requestbuild_overlay.html (+16/-0)
lib/lp/code/javascript/tests/test_requestbuild_overlay.js (+55/-24)
lib/lp/code/javascript/tests/test_util.html (+85/-0)
lib/lp/code/javascript/tests/test_util.js (+90/-0)
lib/lp/code/javascript/util.js (+23/-9)
lib/lp/code/templates/branch-import-details.pt (+10/-11)
lib/lp/code/templates/branch-listing.pt (+1/-3)
lib/lp/code/templates/branchmergeproposal-generic-listing.pt (+5/-13)
lib/lp/code/templates/daily-builds-listing.pt (+1/-3)
lib/lp/code/templates/sourcepackagerecipe-index.pt (+7/-18)
lib/lp/translations/javascript/importqueue.js (+4/-0)
lib/lp/translations/javascript/tests/test_importqueue.html (+110/-0)
lib/lp/translations/javascript/tests/test_importqueue.js (+67/-0)
lib/lp/translations/templates/pofile-export.pt (+2/-1)
lib/lp/translations/templates/translation-import-queue-macros.pt (+8/-10)
| William Grant (wgrant) wrote | #1 |
| Changed in launchpad: | |
| assignee: | nobody → Curtis Hovey (sinzui) |
| status: | Triaged → In Progress |
| Launchpad QA Bot (lpqabot) wrote | #2 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
| tags: | added: disclosure sharing |
I have a branch which removes the anti-IE guard, but we should also have a non-AJAX fallback.