Ubuntu
gnome-pkg-tools package

File /usr/share/gnome-pkg-tools/control.header contains one blank line to much at the end - Please remove it

Bug #953392 reported by Michael Wisheu on 2012-03-12

This bug affects 2 people

	Status	Importance	Assigned to
gnome-pkg-tools (Debian)	Fix Released	Unknown	debbugs #684503
gnome-pkg-tools (Ubuntu)	Fix Released	High	Logan Rosen
Precise	Fix Released	High	Chris J Arges

Bug Description

SRU Justification:
[Impact]
Gnome-pkg-tools produces non-standard control files. This is fixed in quantal, and is a simple removal of a blank line, thus backported easily to precise.

[Testcase]
See bug below.

[Regression Potential]
Minimal, this is a single removal of a blank line from control.header.

Hi everyone,

I've noticed that the file /usr/share/gnome-pkg-tools/control.header contains one blank line to much at the end of the file. Please remove it because it produces non standard control files.

Example from the package mutter:
File debian/control.in:
-------------------------------------------------
Source: mutter
Section: x11
....
-------------------------------------------------

File debian/control:
-------------------------------------------------
# This file is autogenerated. DO NOT EDIT!
#
# Modifications should be made to debian/control.in instead.
# This file is regenerated automatically in the clean target.

Source: mutter
Section: x11
...
-------------------------------------------------

This extra blank line causes issues with tools like pbuilder (automatic installation of build dependencies doesn't work). Because of the blank line the Source paragraph is no longer the first paragraph in the file. The first paragraph then only consists of comments and thus pbuilder-satisfydepends can't determine the build dependencies which yields a build failure because of missing build dependencies...

References:
http://www.debian.org/doc/debian-policy/ch-controlfields.html#s-sourcecontrolfiles
Quote: "The first paragraph of the control file contains information about the source package in general. The subsequent sets each describe a binary package that the source tree builds."

https://answers.launchpad.net/launchpad/+question/151535
Quote: "The problem is the blank line in your debian/control file separating the commented out block and the initial "Source: gnome-orca" paragraph. A very strict reading of the Debian Policy Manual says this is invalid: you have an empty initial paragraph, and the Source paragraph as the second paragraph. Some tools may be more tolerant and skip the initial empty paragraph, however pbuilder-satisfydepends does not."

Please fix this little issue asap because it blocks automatic builds with pbuilder for certain Gnome packages.
This issue is present in all package versions from Lucid up to Precise. Please also note that not all editors show the additional blank line. You could use a hex editor to get rid of the last 0a in the file.

$ xxd /usr/share/gnome-pkg-tools/control.header
...
00000a0: 2074 6172 6765 742e 0a0a target...

Best,

Michael

See original description

Tags:

Related branches

lp:~logan/ubuntu/quantal/gnome-pkg-tools/fixes-953392

Merged into lp:ubuntu/quantal/gnome-pkg-tools at revision 20

Luke Yelavich (community): Approve on 2012-08-15

Ubuntu branches: Pending requested 2012-07-30

lp:ubuntu/quantal/gnome-pkg-tools

lp:ubuntu/precise-proposed/gnome-pkg-tools

Colin Watson (cjwatson) on 2012-07-20

Changed in gnome-pkg-tools (Ubuntu):
status:	New → Triaged
importance:	Undecided → High

Logan Rosen (logan) on 2012-07-30

Changed in gnome-pkg-tools (Ubuntu):
status:	Triaged → In Progress
assignee:	nobody → Logan Rosen (logan)

Revision history for this message

Launchpad Janitor (janitor) wrote on 2012-08-15:

This bug was fixed in the package gnome-pkg-tools - 0.19.3ubuntu2

---------------
gnome-pkg-tools (0.19.3ubuntu2) quantal; urgency=low

* Remove blank line at end of control.header. (LP: #953392)
-- Logan Rosen <email address hidden> Mon, 30 Jul 2012 03:54:42 -0400

Changed in gnome-pkg-tools (Ubuntu):
status:	In Progress → Fix Released

Revision history for this message

Michael Wisheu (wisheu) wrote on 2012-08-15:

Are there any plans to backport this fix?
I would highly appreciate if it would get at least backported to Precise...

Bug Watch Updater (bug-watch-updater) on 2012-08-15

Changed in gnome-pkg-tools (Debian):
status:	Unknown → New

Revision history for this message

Logan Rosen (logan) wrote on 2012-08-15:

Michael, if you need a fix for the bug in previous versions of Ubuntu, please follow the instructions for "Requesting a Backport" at https://wiki.ubuntu.com/UbuntuBackports#Requesting_a_Backport

Revision history for this message

Michael Wisheu (wisheu) wrote on 2012-08-16:

Hi Logan,

Thanks for the information.
I've filed bug https://bugs.launchpad.net/precise-backports/+bug/1037528.

Best,

Michael

Revision history for this message

Chris J Arges (arges) wrote on 2012-08-29:

Reading this bug, it seems like an SRU for precise would make more sense than an entire backport of the package, since this is a one-line change.

Changed in gnome-pkg-tools (Ubuntu Precise):
importance:	Undecided → High
status:	New → Confirmed

Revision history for this message

Michael Wisheu (wisheu) wrote on 2012-08-30:

Fine with me as long as an updated package will be available for Precise.

Revision history for this message

Chris J Arges (arges) wrote on 2012-09-07:

fix_lp953392_precise.debdiff Edit (1.0 KiB, text/plain)

Here is a backport of Logan's patch for Precise.

Changed in gnome-pkg-tools (Ubuntu Precise):
assignee:	nobody → Chris J Arges (christopherarges)
status:	Confirmed → In Progress
description:	updated

Revision history for this message

Michael Wisheu (wisheu) wrote on 2012-09-10:

Hi everyone,

I've started to think about this issue again after I've read "Regression Potential"...
I think it is easy for someone to accidently/unknowingly reintroduce this bug! I think it would be wise to harden gnome-pkg-tools against this issue by stripping any blank lines at the end of the control.header file before the content of the file is used.

What do you guys think?

Best,

Michael

Revision history for this message

Martin Pitt (pitti) wrote on 2012-09-10:

Makes sense to me to get this fixed in precise as well, as it's a fairly popular development platform. I uploaded the fix to the precise-proposed queue, unsubscribing sponsors now. Thanks!

Revision history for this message

Adam Conrad (adconrad) wrote on 2012-09-10: Please test proposed package

#10

Hello Michael, or anyone else affected,

Accepted gnome-pkg-tools into precise-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/gnome-pkg-tools/0.19.1ubuntu3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please change the bug tag from verification-needed to verification-done. If it does not, change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

Changed in gnome-pkg-tools (Ubuntu Precise):
status:	In Progress → Fix Committed
tags:	added: verification-needed

Revision history for this message

Chris J Arges (arges) wrote on 2012-10-01:

#11

This is fixed in Precise in the -proposed package.

tags:

added: verification-done
removed: verification-needed

Revision history for this message

Scott Kitterman (kitterman) wrote on 2012-10-02: Update Released

#12

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

Revision history for this message

Launchpad Janitor (janitor) wrote on 2012-10-02:

#13

This bug was fixed in the package gnome-pkg-tools - 0.19.1ubuntu3

---------------
gnome-pkg-tools (0.19.1ubuntu3) precise-proposed; urgency=low

[ Logan Rosen ]
* Remove blank line at end of control.header. (LP: #953392)
-- Chris J Arges <email address hidden> Fri, 07 Sep 2012 14:48:19 -0500

Changed in gnome-pkg-tools (Ubuntu Precise):
status:	Fix Committed → Fix Released

Revision history for this message

Michael Wisheu (wisheu) wrote on 2012-10-03:

#14

Thanks for the fixed gnome-pkg-tools package. It works like a charm.
One note from my side... If you use pbuilder you have to add precise-proposed via the othermirror option.
(--othermirror "deb http://archive.ubuntu.com/ubuntu precise-proposed main restricted universe multiverse")