Runing tests with LANG set makes some tests fail
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| Ubuntu One Control Panel | Status tracked in Trunk | |||||
| Stable-3-0 |
Fix Released
|
Undecided
|
Unassigned | |||
| Trunk |
Fix Released
|
Low
|
Roberto Alsina | |||
| Ubuntu Single Sign On Client | Status tracked in Trunk | |||||
| Stable-3-0 |
Fix Released
|
Undecided
|
Unassigned | |||
| Trunk |
Fix Released
|
Low
|
Roberto Alsina | |||
Bug Description
Trunk , revno 280:
If you run the tests like this:
LANG=es_ES.UTF-8 ./run-tests
These tests fail:
[FAIL]
Traceback (most recent call last):
File "/home/
tooltip=
File "/home/
self.
File "/usr/lib/
% (msg, pformat(first), pformat(second)))
twisted.
a = u'La sincronizaci\xf3n de archivos est\xe1 desactivada.'
b = PyQt4.QtCore.
ubuntuone.
=======
[FAIL]
Traceback (most recent call last):
File "/home/
tooltip=
File "/home/
self.
File "/usr/lib/
% (msg, pformat(first), pformat(second)))
twisted.
a = u'La sincronizaci\xf3n de archivos est\xe1 desconectada.'
b = PyQt4.QtCore.
ubuntuone.
=======
[FAIL]
Traceback (most recent call last):
File "/home/
tooltip=
File "/home/
self.
File "/usr/lib/
% (msg, pformat(first), pformat(second)))
twisted.
a = u'<font color="
b = PyQt4.QtCore.
ubuntuone.
=======
[FAIL]
Traceback (most recent call last):
File "/home/
tooltip=
File "/home/
self.
File "/usr/lib/
% (msg, pformat(first), pformat(second)))
twisted.
a = u'Sincronizaci\xf3n de archivos actualizada.'
b = PyQt4.QtCore.
ubuntuone.
=======
[FAIL]
Traceback (most recent call last):
File "/home/
tooltip=
File "/home/
self.
File "/usr/lib/
% (msg, pformat(first), pformat(second)))
twisted.
a = u'Iniciando sincronizaci\xf3n de archivos...'
b = PyQt4.QtCore.
ubuntuone.
=======
[FAIL]
Traceback (most recent call last):
File "/home/
tooltip=
File "/home/
self.
File "/usr/lib/
% (msg, pformat(first), pformat(second)))
twisted.
a = u'Sincronizaci\xf3n de archivos detenida.'
b = PyQt4.QtCore.
ubuntuone.
=======
[FAIL]
Traceback (most recent call last):
File "/home/
tooltip=
File "/home/
self.
File "/usr/lib/
% (msg, pformat(first), pformat(second)))
twisted.
a = u'Sincronizaci\xf3n de archivos en progreso...'
b = PyQt4.QtCore.
ubuntuone.
=======
[FAIL]
Traceback (most recent call last):
File "/home/
tooltip=
File "/home/
self.
File "/usr/lib/
% (msg, pformat(first), pformat(second)))
twisted.
a = u'<font color="
b = PyQt4.QtCore.
ubuntuone.
-------
Ran 855 tests in 9.692s
FAILED (skips=2, failures=8, successes=845)
Related branches
- Natalia Bidart (community): Approve
- dobey (community): Approve
-
Diff: 210 lines (+32/-26)8 files modifiedubuntuone/controlpanel/gui/qt/tests/test_account.py (+4/-4)
ubuntuone/controlpanel/gui/qt/tests/test_controlpanel.py (+4/-3)
ubuntuone/controlpanel/gui/qt/tests/test_device.py (+2/-1)
ubuntuone/controlpanel/gui/qt/tests/test_devices.py (+3/-3)
ubuntuone/controlpanel/gui/qt/tests/test_filesyncstatus.py (+6/-4)
ubuntuone/controlpanel/gui/qt/tests/test_folders.py (+8/-7)
ubuntuone/controlpanel/gui/qt/tests/test_signin.py (+4/-3)
ubuntuone/controlpanel/gui/qt/tests/test_wizard.py (+1/-1)
- Natalia Bidart (community): Approve
- dobey (community): Approve
-
Diff: 139 lines (+28/-18)8 files modifiedubuntu_sso/qt/tests/test_current_user_sign_in_page.py (+7/-4)
ubuntu_sso/qt/tests/test_email_verification.py (+1/-1)
ubuntu_sso/qt/tests/test_forgotten_password.py (+3/-2)
ubuntu_sso/qt/tests/test_reset_password.py (+5/-3)
ubuntu_sso/qt/tests/test_setup_account.py (+8/-5)
ubuntu_sso/qt/tests/test_ssl_dialog.py (+2/-1)
ubuntu_sso/utils/runner/glib.py (+1/-1)
ubuntu_sso/utils/runner/tx.py (+1/-1)
- Roberto Alsina (community): Approve
-
Diff: 5121 lines (+2191/-925)62 files modifiedbin/ubuntu-sso-login-qt (+6/-3)
bin/ubuntu-sso-proxy-creds-qt (+6/-3)
data/qt/linux.qss (+2/-0)
data/qt/loadingoverlay.ui (+0/-5)
data/qt/proxy_credentials_dialog.ui (+0/-2)
data/qt/reset_password.ui (+199/-262)
data/qt/resources.qrc (+2/-0)
data/qt/setup_account.ui (+1/-36)
data/qt/ssl_dialog.ui (+0/-5)
data/qt/stylesheet.qss (+1/-13)
data/qt/windows.qss (+5/-0)
po/POTFILES.in (+1/-0)
run-tests (+1/-1)
ubuntu_sso/__init__.py (+8/-0)
ubuntu_sso/gtk/gui.py (+18/-33)
ubuntu_sso/gtk/tests/test_gui.py (+34/-5)
ubuntu_sso/qt/__init__.py (+33/-5)
ubuntu_sso/qt/common.py (+3/-3)
ubuntu_sso/qt/current_user_sign_in_page.py (+13/-12)
ubuntu_sso/qt/email_verification_page.py (+8/-5)
ubuntu_sso/qt/enhanced_check_box.py (+9/-3)
ubuntu_sso/qt/forgotten_password_page.py (+5/-1)
ubuntu_sso/qt/loadingoverlay.py (+3/-1)
ubuntu_sso/qt/main.py (+12/-3)
ubuntu_sso/qt/network_detection_page.py (+5/-1)
ubuntu_sso/qt/proxy_dialog.py (+4/-7)
ubuntu_sso/qt/reset_password_page.py (+6/-2)
ubuntu_sso/qt/setup_account_page.py (+19/-18)
ubuntu_sso/qt/sso_wizard_page.py (+116/-76)
ubuntu_sso/qt/tests/__init__.py (+55/-7)
ubuntu_sso/qt/tests/login_u_p.py (+0/-2)
ubuntu_sso/qt/tests/show_gui.py (+0/-2)
ubuntu_sso/qt/tests/test_common.py (+130/-2)
ubuntu_sso/qt/tests/test_current_user_sign_in_page.py (+28/-17)
ubuntu_sso/qt/tests/test_email_verification.py (+6/-7)
ubuntu_sso/qt/tests/test_enhanced_check_box.py (+19/-1)
ubuntu_sso/qt/tests/test_forgotten_password.py (+6/-4)
ubuntu_sso/qt/tests/test_loadingoverlay.py (+0/-3)
ubuntu_sso/qt/tests/test_main.py (+108/-12)
ubuntu_sso/qt/tests/test_proxy_dialog.py (+2/-2)
ubuntu_sso/qt/tests/test_reset_password.py (+9/-17)
ubuntu_sso/qt/tests/test_setup_account.py (+55/-71)
ubuntu_sso/qt/tests/test_ssl_dialog.py (+2/-1)
ubuntu_sso/qt/tests/test_sso_wizard_page.py (+98/-59)
ubuntu_sso/qt/tests/test_ubuntu_sso_wizard.py (+36/-6)
ubuntu_sso/qt/ubuntu_sso_wizard.py (+19/-2)
ubuntu_sso/utils/__init__.py (+15/-2)
ubuntu_sso/utils/linux.py (+19/-0)
ubuntu_sso/utils/runner/glib.py (+1/-1)
ubuntu_sso/utils/runner/tx.py (+1/-1)
ubuntu_sso/utils/tests/test_common.py (+10/-1)
ubuntu_sso/utils/ui.py (+7/-1)
ubuntu_sso/utils/webclient/__init__.py (+18/-2)
ubuntu_sso/utils/webclient/common.py (+110/-2)
ubuntu_sso/utils/webclient/gsettings.py (+21/-14)
ubuntu_sso/utils/webclient/libsoup.py (+48/-4)
ubuntu_sso/utils/webclient/qtnetwork.py (+124/-22)
ubuntu_sso/utils/webclient/tests/__init__.py (+74/-6)
ubuntu_sso/utils/webclient/tests/test_gsettings.py (+44/-61)
ubuntu_sso/utils/webclient/tests/test_webclient.py (+510/-10)
ubuntu_sso/utils/webclient/txweb.py (+77/-78)
ubuntu_sso/utils/windows.py (+19/-0)
| Changed in ubuntuone-control-panel: | |
| assignee: | nobody → Roberto Alsina (ralsina) |
| status: | New → In Progress |
| Roberto Alsina (ralsina) wrote | #1 |
| Changed in ubuntu-sso-client: | |
| assignee: | nobody → Roberto Alsina (ralsina) |
| status: | New → Triaged |
| importance: | Undecided → Low |
| Changed in ubuntuone-control-panel: | |
| status: | In Progress → Fix Committed |
| Changed in ubuntu-sso-client: | |
| status: | Triaged → Fix Committed |
There is some weirdness about comparing QStrings and unicodes:
>>> u'a' == QtCore.
True
>>> u'á' == QtCore.
__main__:1: UnicodeWarning: Unicode equal comparison failed to convert both arguments to Unicode - interpreting them as being unequal
False
>>> u'á' == unicode(
True
Therefore, whenever we compare unicode to strings we get from Qt (like using widget.text() or whatever), we need to manually convert the QString to unicode prior to comparison.
These 9 tests fail on spanish because they are the 9 strings we are comparing that have non-ascii characters in them. In other locales other tests may fail.