[UIFe] String and feature changes in new Rhythmbox
Bug #949424 reported by
dobey
This bug affects 2 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| rhythmbox (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | ||
Bug Description
I have a preview release tarball to update Rhythmbox to what is currently in trunk with, and upstream is planning to make another release in the next weekend as well.
There are several string changes, and a few feature changes, in the package as a result.
Features:
- Removal of gtk_dialog_run usage in all but one special case.
- Allow plug-ins to specify they should be enabled by default (regression already approved in bug #934235)
- Porting of more plug-ins and example scripts to PyGI/GIO/GDBus
Strings:
"LIRC" instead of "LIRC " (This can be updated with a simple search/replace.)
There are also some string changes in the magnatune plug-in which we are not currently shipping (as it was disabled for a while upstream, from building). We might want to package it again, as it is re-enabled now.
I also have some binary packaging changes I'd like to make, to reduce dependencies of additional external plug-ins, and make it easier to uninstall some plug-ins. This includes moving some of the existing plug-ins into the main rhythmbox package, as they are intended to be enabled by default upstream, and some of them are needed by other plug-ins (like the special rb plug-in). These plug-ins are:
audiocd
generic-player
iradio
mmkeys
power-manager
rb
Further splitting would also include the following new binary packages:
rhythmbox-mozilla - the itms detection NPAPI plug-in for browsers
rhythmbox-
rhythmbox-
rhythmbox-
Related branches
lp:~dobey/ubuntu/precise/rhythmbox/prereleases-2-95-5
- Martin Pitt: Approve
-
Diff: 86803 lines (+21230/-36496)179 files modified.pc/01_lpi.patch/configure.ac (+0/-988)
.pc/01_lpi.patch/data/ui/rhythmbox-ui.xml (+0/-330)
.pc/01_lpi.patch/shell/rb-shell.c (+0/-4126)
.pc/02_use_escaped_podcast_uri.patch/podcast/rb-podcast-manager.c (+0/-2203)
.pc/03_magnatune_partner.patch/plugins/magnatune/MagnatuneSource.py (+0/-560)
.pc/04_pause_button.patch/shell/rb-shell-player.c (+0/-3942)
.pc/05_hide_on_quit.patch/shell/rb-shell.c (+0/-4131)
.pc/05_hide_on_quit.patch/shell/rb-shell.h (+0/-170)
.pc/applied-patches (+0/-6)
.pc/git_use_correct_mpris_name.patch/plugins/mpris/rb-mpris-plugin.c (+0/-1644)
ChangeLog (+843/-1)
Makefile.in (+3/-3)
NEWS (+13/-0)
README (+1/-1)
backends/gstreamer/rb-encoder-gst.c (+14/-6)
backends/rb-encoder.c (+4/-28)
backends/rb-encoder.h (+4/-3)
bindings/gi/MPID-3.0.gir (+4/-2)
bindings/gi/Makefile.am (+4/-0)
bindings/gi/Makefile.in (+4/-0)
bindings/gi/RB-3.0.gir (+378/-106)
config.h.in (+12/-0)
configure (+88/-23)
configure.ac (+10/-6)
data/org.gnome.rhythmbox.gschema.xml (+10/-3)
data/ui/rhythmbox-ui.xml (+0/-1)
debian/changelog (+25/-1)
debian/control (+85/-18)
debian/control.in (+85/-13)
debian/patches/01_lpi.patch (+14/-14)
debian/patches/02_use_escaped_podcast_uri.patch (+5/-16)
debian/patches/03_magnatune_partner.patch (+6/-8)
debian/patches/git_use_correct_mpris_name.patch (+0/-24)
debian/patches/series (+0/-1)
debian/rhythmbox-mozilla.install (+2/-0)
debian/rhythmbox-plugin-coherence.install (+0/-1)
debian/rhythmbox-plugin-magnatune.install (+3/-0)
debian/rhythmbox-plugin-visualizer.install (+3/-0)
debian/rhythmbox-plugin-zeitgeist.install (+2/-0)
debian/rhythmbox-plugins.install (+0/-15)
debian/rhythmbox.install (+12/-3)
doc/reference/html/RBEncoder.html (+7/-31)
doc/reference/html/RBShell.html (+1/-1)
doc/reference/html/RBSource.html (+1/-2)
doc/reference/html/RBTrackTransferBatch.html (+7/-6)
doc/reference/html/RhythmDB.html (+4/-10)
doc/reference/html/RhythmDBQueryModel.html (+1/-2)
doc/reference/html/ch01.html (+1/-1)
doc/reference/html/ch02.html (+1/-1)
doc/reference/html/ch03.html (+1/-1)
doc/reference/html/ch04.html (+1/-1)
doc/reference/html/ch05.html (+1/-1)
doc/reference/html/ch06.html (+1/-1)
doc/reference/html/ch07.html (+1/-1)
doc/reference/html/index.sgml (+0/-1)
doc/reference/html/rhythmbox-rb-debug.html (+3/-8)
doc/reference/html/rhythmbox-rb-rating-helper.html (+1/-2)
doc/reference/html/rhythmbox.devhelp2 (+0/-1)
doc/reference/rhythmbox.types (+2/-0)
doc/reference/tmpl/rb-encoder.sgml (+1/-10)
doc/reference/tmpl/rb-track-transfer-batch.sgml (+0/-1)
doc/reference/tmpl/rhythmbox-unused.sgml (+9/-0)
lib/Makefile.am (+5/-1)
lib/Makefile.in (+5/-2)
lib/rb-async-copy.c (+237/-0)
lib/rb-async-copy.h (+82/-0)
lib/rb-chunk-loader.c (+314/-0)
lib/rb-chunk-loader.h (+79/-0)
lib/rb-file-helpers.c (+2/-1)
lib/rb-gst-media-types.c (+5/-0)
lib/rb-tree-dnd.c (+5/-1)
ltmain.sh (+1/-1)
macros/gsettings.m4 (+26/-11)
metadata/rb-ext-db-key.c (+3/-3)
metadata/rb-metadata-dbus-service.c (+5/-1)
metadata/rb-metadata-gst.c (+93/-24)
plugins/artdisplay/artdisplay.plugin.in (+3/-0)
plugins/artsearch/artsearch.plugin.in (+3/-0)
plugins/audiocd/rb-audiocd-source.c (+208/-170)
plugins/audiocd/sj-metadata-marshal.c (+1/-1)
plugins/audioscrobbler/audioscrobbler.plugin.in (+3/-0)
plugins/audioscrobbler/rb-audioscrobbler-profile-page.c (+2/-2)
plugins/audioscrobbler/rb-audioscrobbler-radio-source.c (+1/-1)
plugins/brasero-disc-recorder/cd-recorder.plugin.in (+3/-0)
plugins/daap/Makefile.am (+0/-2)
plugins/daap/Makefile.in (+0/-12)
plugins/daap/daap.plugin.in (+3/-0)
plugins/daap/rb-daap-dialog.c (+0/-100)
plugins/daap/rb-daap-dialog.h (+0/-42)
plugins/daap/rb-daap-plugin.c (+8/-2)
plugins/daap/rb-daap-source.c (+0/-1)
plugins/dbus-media-server/dbus-media-server.plugin.in (+3/-0)
plugins/dbus-media-server/rb-dbus-media-server-plugin.c (+47/-27)
plugins/fmradio/rb-fm-radio-source.c (+8/-2)
plugins/grilo/rb-grilo-source.c (+1/-1)
plugins/im-status/im-status.py (+53/-104)
plugins/ipod/ipod.plugin.in (+3/-0)
plugins/ipod/rb-ipod-db.c (+2/-0)
plugins/ipod/rb-ipod-helpers.c (+2/-81)
plugins/ipod/rb-ipod-helpers.h (+1/-2)
plugins/ipod/rb-ipod-plugin.c (+0/-13)
plugins/ipod/rb-ipod-source.c (+145/-9)
plugins/iradio/iradio-initial.xspf (+14/-0)
plugins/iradio/rb-iradio-source.c (+12/-5)
plugins/lirc/Makefile.am (+1/-1)
plugins/lirc/Makefile.in (+1/-1)
plugins/lirc/lirc.plugin.in (+0/-8)
plugins/lirc/rblirc.plugin.in (+8/-0)
plugins/lyrics/TerraParser.py (+3/-1)
plugins/lyrics/lyrics.py (+1/-1)
plugins/magnatune/BuyAlbumHandler.py (+0/-59)
plugins/magnatune/DownloadAlbumHandler.py (+59/-0)
plugins/magnatune/MagnatuneAccount.py (+89/-0)
plugins/magnatune/MagnatuneSource.py (+127/-143)
plugins/magnatune/Makefile.am (+8/-9)
plugins/magnatune/Makefile.in (+155/-22)
plugins/magnatune/TrackListHandler.py (+1/-14)
plugins/magnatune/magnatune-loading.ui (+46/-208)
plugins/magnatune/magnatune-prefs.ui (+166/-176)
plugins/magnatune/magnatune.py (+73/-99)
plugins/mpris/mpris.plugin.in (+3/-0)
plugins/mtpdevice/mtpdevice.plugin.in (+3/-0)
plugins/mtpdevice/rb-mtp-source.c (+10/-3)
plugins/mtpdevice/rb-mtp-thread.c (+1/-0)
plugins/notification/notification.plugin.in (+3/-0)
plugins/rb/Loader.py (+0/-84)
plugins/rb/rb.py (+0/-1)
plugins/sample-vala/rb-sample-vala-plugin.c (+2/-2)
po/POTFILES.in (+1/-2)
po/be.po (+885/-886)
po/bg.po (+1279/-1252)
po/ca.po (+2/-2)
po/cs.po (+754/-864)
po/de.po (+65/-63)
po/eo.po (+1366/-1317)
po/es.po (+927/-935)
po/gl.po (+1141/-1109)
po/lt.po (+405/-360)
po/nb.po (+1712/-1734)
po/pl.po (+272/-383)
po/pt_BR.po (+2586/-2467)
po/sl.po (+922/-877)
po/sr.po (+939/-939)
po/sr@latin.po (+939/-939)
po/sv.po (+2340/-1766)
po/te.po (+289/-304)
podcast/rb-podcast-main-source.c (+20/-8)
podcast/rb-podcast-manager.c (+86/-62)
podcast/rb-podcast-manager.h (+7/-6)
podcast/rb-podcast-source.c (+88/-69)
remote/dbus/rb-set-rating.py (+17/-8)
rhythmdb/rhythmdb-dbus.c (+17/-6)
rhythmdb/rhythmdb-tree.c (+1/-0)
rhythmdb/rhythmdb.c (+1/-1)
shell/main.c (+2/-0)
shell/rb-playlist-manager.c (+39/-17)
shell/rb-shell-player.c (+19/-13)
shell/rb-shell.c (+73/-48)
shell/rb-shell.h (+0/-2)
shell/rb-track-transfer-batch.c (+93/-52)
shell/rb-track-transfer-batch.h (+3/-0)
shell/rb-track-transfer-queue.c (+51/-32)
sources/rb-auto-playlist-source.c (+1/-1)
sources/rb-browser-source.c (+1/-1)
sources/rb-import-errors-source.c (+1/-1)
sources/rb-library-source.c (+25/-16)
sources/rb-static-playlist-source.c (+1/-1)
sources/rb-transfer-target.c (+3/-3)
sources/sync/rb-sync-state-ui.c (+1/-1)
widgets/gossip-cell-renderer-expander.c (+5/-1)
widgets/rb-alert-dialog.c (+2/-2)
widgets/rb-cell-renderer-pixbuf.c (+5/-1)
widgets/rb-cell-renderer-rating.c (+5/-1)
widgets/rb-header.c (+5/-5)
widgets/rb-query-creator-properties.c (+2/-2)
widgets/rb-query-creator.c (+1/-1)
widgets/rb-rating.c (+3/-1)
widgets/rb-song-info.c (+1/-1)
widgets/test-rb-segmented-bar.c (+1/-1)
| description: | updated |
| description: | updated |
Revision history for this message
| Martin Pitt (pitti) wrote Re: [Bug 949424] [NEW] [UIFe] String and feature changes in new Rhythmbox | #1 |
| Changed in rhythmbox (Ubuntu): | |
| status: | New → Confirmed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #2 |
| Changed in rhythmbox (Ubuntu): | |
| status: | Confirmed → Fix Released |
To post a comment you must log in.
Launchpad Bug Tracker [2012-03-07 21:47 -0000]:
> Features:
>
> - Removal of gtk_dialog_run usage in all but one special case.
Sounds fine.
> - Allow plug-ins to specify they should be enabled by default (regression already approved in bug #934235)
That sounds very welcome indeed, and I count this as a bug fix
actually.
> - Porting of more plug-ins and example scripts to PyGI/GIO/GDBus
Sounds fine, as they currently would not even run with pygtk, so again
bug fixes.
> Strings:
>
> "LIRC" instead of "LIRC " (This can be updated with a simple
> search/replace.)
Approved. It's a proper noun and acronym anyway, so I doubt it even
should be translated.
> There are also some string changes in the magnatune plug-in which we are
> not currently shipping (as it was disabled for a while upstream, from
> building). We might want to package it again, as it is re-enabled now.
Approved.
> I also have some binary packaging changes I'd like to make, to reduce
> dependencies of additional external plug-ins, and make it easier to
> uninstall some plug-ins.
FF wise I'm ok with this, but this should be coordinated with Debian.
This is quite an invasive packaging change, and we don't want to
carry it forever.
Martin
--
Martin Pitt | http://
Ubuntu Developer (www.ubuntu.com) | Debian Developer (www.debian.org)