whois doesn't properly query .hr/.sx/.pe TLDs and incorrect format for whois.arin.net

Backporting whois from 5.0.14ubuntu1 to oneiric fixes the issue.

I have produced a build with the backport here:
http://people.canonical.com/~arges/lp943502/

whois 5.0.15 was just released with fixes for two other TLDs (including .pe, which wasn't correctly fixed in 5.0.14). Would be nice to pick those fixes up as well.

@ReedMerged 5.0.15 as well, thanks for the tip!

@Chris J Arges, I've also subscribed ubuntu-sponsors so sponsors can take a look at your oneiric fix.

@Chris

Thanks for taking the time to work on this bug.

Its a little unclear from this bug report as to whether you are requesting a backport of 5.0.14/25 from precise to oneiric (as in the attached files) OR you want to SRU the required fixes into oneiric (as in the description for this bug).

The process is a little different for each and the outcome is supported differently:

Backports: https://wiki.ubuntu.com/UbuntuBackports

SRU: https://wiki.ubuntu.com/StableReleaseUpdates

I'm going to un-subscribe ubuntu-sponsors for the time being.

Please re-subscribe this team to the bug report when you feel its ready for further review.

Thanks

James

@james
I'd like to go through the backport process.

Since this bug makes it sound like we might as well backport 5.0.15 instead of 5.0.14 (since .pe was incorrect and we pick up a few fixes), the existing patch is insufficient. So I'll unsubscribe sponsors. Please re-subscribe when there is an actionable patch.

Ok I'll start the backport process. Building it now.

Adding a backports task as this is the direction this bug is going instead of an SRU.

This patch backports the precise whois version to oneiric. There are no changes, except changing the config.h VERSION constant to match the changelog version.

Per the discussion on IRC, it would be preferred to patch the rules file to be sane with backport versions and upstream this to Debian as we currently don't carry a diff for this.

Send a bug to Debian requesting this change:
http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=671097

No change backport. This is slightly different than what backportpackage came up with because I did need to change the version string from 5.0.17~oneiric1 to 5.0.17ubuntu1~oneiric1. This works now because the maintainer added the simple patch to correctly detect version backport strings.

So we can't backport because of the version string check in debian/rules. I proposed just removing it entirely in debian here: http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=684526

If this gets fixed, then backporting will be possible.

Sent a new patch to debian.

This now cleanly backports to oneiric from quantal.
Using:
  backportpackage -s quantal -d oneiric -B pbuilder-dist -b whois -w .

Chris, since this is in quantal now, we'll need to backport through precise, so we'll need the reverse dependencies tested with the latest version of whois built on oneiric and precise.

Ok backports cleanly to Precise as well. Did the tests, attached the requestbackport output to the description. Thanks

FWIW: Build is here: https://launchpad.net/~christopherarges/+archive/ppa-test/+sourcepub/2698908/+listing-archive-extra

Ok instead of going the Ubuntu backports route, I just created a patch that enabled these feature in Oneiric.
I've linked a branch with these changes.
I've also built/tested on my end and it does in fact pass the test case.

You can't enable features in an SRU.

@Micah I could argue this is a bug rather than a feature. Not being able to query and adding fixes to the ARIN side is more a fix than enhancement. Also, these code changes are minimal.

At this point, I've already requested a backport in October, so I can copy and paste that again.
However, I spoke with infinity about this bug yesterday and he recommended an SRU, which is why I created that patch.
While I said the patch 'enables' these features, it really fixes the legitimate ARIN format issue, and puts in the correct .pe whois server. The .hr/.sx servers are simply added to the tld_serv_list along with the encodings which is a fairly small change.

So either way, I'd like to get this fixed.

It's not clear to me at this point what we request to be sponsored exactly and where ... there are no debdiff for oneiric on this bug out of weird almost empty changelog ones

ok, discussed on IRC and sponsoring the vcs attached to the bug

BTW, as an SRU team member, +1 for this going through. Its not so much a feature as severely broken by missing functionality. We also make exceptions for "features" that enable access to hardware and/or services external to Ubuntu.

Hello Chris, or anyone else affected,

Accepted whois into oneiric-proposed. The package will build now and be available at http://launchpad.net/ubuntu/+source/whois/5.0.11ubuntu3 in a few hours, and then in the -proposed repository.

Please help us by testing this new package. See https://wiki.ubuntu.com/Testing/EnableProposed for documentation how to enable and use -proposed. Your feedback will aid us getting this update out to other Ubuntu users.

If this package fixes the bug for you, please add a comment to this bug, mentioning the version of the package you tested, and change the tag from verification-needed to verification-done. If it does not fix the bug for you, please add a comment stating that, and change the tag to verification-failed. In either case, details of your testing will help us make a better decision.

Further information regarding the verification process can be found at https://wiki.ubuntu.com/QATeam/PerformingSRUVerification . Thank you in advance!

I have just verified this works and passes all the test cases.

The verification of this Stable Release Update has completed successfully and the package has now been released to -updates. Subsequently, the Ubuntu Stable Release Updates Team is being unsubscribed and will not receive messages about this bug report. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we can easily find any regresssions.

This bug was fixed in the package whois - 5.0.11ubuntu3

---------------
whois (5.0.11ubuntu3) oneiric-proposed; urgency=low

  * Backport changes to fix whois doesn't properly query .hr/.sx/.pe TLDs
    and incorrect format for whois.arin.net (LP: #943502)
    - Add the "+" flag by default to queries to whois.arin.net if the
      argument looks like an IP address. Also add the "a" and "n" flags.
      No thanks to ARIN for breaking every whois client.
    - Updated the .hr TLD server. (Closes: #646572)
    - Added the .sx TLD server.
    - Updated the .pe TLD server, this time for real. (Closes: #653105)
 -- Chris J Arges <email address hidden> Wed, 05 Dec 2012 15:22:30 -0600