VM

message/external-body issues

Bug #941561 reported by Uday Reddy
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
VM
Fix Committed
High
Uday Reddy

Bug Description

Message had an attachment, and I did `vm-save-all-attachments'. The button showed

  [PDF: external: full1.pdf, PDF ...]

Then I hit return on the external attachment in order to view it, and it became two buttons:

 [PDF: full1.pdf, PDF]
 [PDF: external: full1.pdf, PDF ...]

If I hit return once more then another copy of the first line is generated.

I went to the first line and hit return in order to view it, and that worked.

Then I saved this retrieved version of the attachment via the first button. Then it became

  [Deleted full1.pdf (PDF)]
  [PDF: external: full1.pdf, PDF ...]

Hitting further return on this button didn't help.

Hitting return on the second button created a yet another button, but with an error message:

  [Deleted full1.pdf (PDF)]
  [MIME part missing header/body separator line]
  [PDF: external: full1.pdf, PDF ...]

Looking at the text of the message body showed

  [Deleted full1.pdf]
  [Saved to ...]
  --=_FvASF1Lxr25PSVxNK4KTb6A--

The original text part of the message was gone. The Content-Type in the header of the message had application/pdf, whereas it should have been multipart/mixed.

Trying to refresh the message from the server gave an error message

  VM internal error: headers of a message have been corrupted. Continue? (y or n)

Doing vm-decode-message shows that the message was indeed corrupted.

Related branches

Uday Reddy (reddyuday)
tags: added: external-body
Revision history for this message
Uday Reddy (reddyuday) wrote :

In rev. 1039, Bug 715268 was handled, which is essentially an earlier version of the current bug.

display-button-message/external-body to encapsulate the work of internal-display-message/external-body. But the comment says that no new buttons should be created for the external-body content. That is apparently not being respected now.

Revision history for this message
Uday Reddy (reddyuday) wrote :

Bug 911903 might have had a similar issue with attachment buttons.

Uday Reddy (reddyuday)
tags: added: 8.2
Revision history for this message
Uday Reddy (reddyuday) wrote :

The solution to the first problem is to make the message/external-body buttons to be "vm-mime-disposable". Then they get replaced by their content buttons when fetched. Fix committed in rev. 1381.

Revision history for this message
Uday Reddy (reddyuday) wrote :

The message corruption occurred because vm-mime-discard-layout-contents tacitly assumed that the MIME body was present in the message and went about deleting it, even though it was an external-body.

Fix committed in rev. 1382.

Both the fixes need to be tested.

Changed in vm:
status: Triaged → In Progress
Uday Reddy (reddyuday)
Changed in vm:
status: In Progress → Fix Committed
Uday Reddy (reddyuday)
Changed in vm:
milestone: 8.2.2a → 8.2.1a
Uday Reddy (reddyuday)
Changed in vm:
milestone: 8.2.1a → 8.2.90a
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.