dkms_apport.py reports bugs for unsupported kernel versions

Bug #940285 reported by Felix Geyer
26
This bug affects 5 people
Affects Status Importance Assigned to Milestone
dkms (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

dkms 2.2.0.2-1ubuntu2 introduced a regression which causes apport to report bugs about unsupported kernel versions.
For example bug #939928 is about kernel 3.3.0-rc4-ux31.

- if not apport.packaging.is_distro_package(kernel_package):
- print >> sys.stderr, 'ERROR (dkms apport): kernel package %s is not supported' % (kernel_package,)
- sys.exit(1)
+ try:
+ apport.packaging.is_distro_package(kernel_package)
+ except ValueError, e:
+ if e == 'package does not exist':
+ print >> sys.stderr, 'ERROR (dkms apport): kernel package %s is not supported' % (kernel_package)
+ sys.exit(1)

The result of is_distro_package() isn't checked at all.

Related branches

Revision history for this message
Felix Geyer (debfx) wrote :

Proposed fix:

dkms (2.2.0.3-1ubuntu1) precise; urgency=low

  * Only report bugs about supported kernel versions. This fixes a regression
    introduced in 2.2.0.2-1ubuntu2. (LP: #940285)
    - Add apport_supported_kernel_packages.diff:
      Check the result of is_distro_package() and fix the check if the kernel
      header package is installed at all.

 -- Felix Geyer <email address hidden> Fri, 24 Feb 2012 14:08:47 +0100

Revision history for this message
Daniel Holbach (dholbach) wrote :

Uploaded, thanks for your work on this. It should be sitting in the archive admin review queue.

Do you think you could forward the patch to https://lists.us.dell.com/mailman/listinfo/dkms-devel? (I assume this is the best place for it...)

Changed in dkms (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package dkms - 2.2.0.3-1ubuntu1

---------------
dkms (2.2.0.3-1ubuntu1) precise; urgency=low

  * Only report bugs about supported kernel versions. This fixes a regression
    introduced in 2.2.0.2-1ubuntu2. (LP: #940285)
    - Add apport_supported_kernel_packages.diff:
      Check the result of is_distro_package() and fix the check if the kernel
      header package is installed at all.
 -- Felix Geyer <email address hidden> Fri, 24 Feb 2012 14:08:47 +0100

Changed in dkms (Ubuntu):
status: Fix Committed → Fix Released
Revision history for this message
Bouke Bunnik (bosyber) wrote :

This might not be ontopic for this bug, as I have dkms version 2.2.0.3-1ubuntu1 installed, but what exactly is the intent of the check?

I have kernel-ppa v.3.7.6-030706-generic, with headers installed, but this check seems to stop me from using dkms with it. Same for, for example, the xedgers-ppa kernel 3.7.0-7. Is that intended? It makes it a lot more cumbersome to use these kernels, and makes recompiling kernels and all modules I might want to try myself almost a clean and clear idea. Is there an override?

Sorry if that's al covered somewhere, please point me there if so.

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.