base_contact address required fields

Bug #940264 reported by Julien Thewys
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Invalid
Wishlist
OpenERP R&D Addons Team 1

Bug Description

The new res.partner.address object defined in base_contact needs partner_id and contact_id to be required.
In fact, this new res.partner.address actually represents a job of some contact at some company:
- there is no point of creating a job record without knowing the references to both the person and its employer.
- moreover, allowing all fields to be blank on this object is error prone and does rapidly clutter the address book with partial and/or duplicated records.

For information, this is by opposition to the "original" res.partner.address object (defined in base) where there is no contact_id field and where partner_id may be intentionally left blank so that the address can be seen as a generic address unrelated to a company/partner.

Tags: mso

Related branches

tags: added: mso
Revision history for this message
Etienne Hirt (hirt) wrote :

Dear Julien,

Private addresses do not have a partner assigned
Default addresses for partners that hold switchboard phone etc. do not have a contact assigned.

Please have a look at my work in https://code.launchpad.net/~openerp-community/openobject-addons/trunk-bug-923440-base_contact_finalise6.1

Etienne

Revision history for this message
Julien Thewys (julien-thewys) wrote :

OK then could we say that at least one of them must be non null.
If not, then we have a usability problem, as the record can be saved empty without the user noticing it (from the partner or the contact form, it is easy to create empty address records).

Revision history for this message
Jignesh Rathod(OpenERP) (jir-openerp) wrote :

Hello Julien,

We have already plan to improve base_contact ,
So currently I am setting this as wishlist.

Thank you!

Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 1 (openerp-dev-addons1)
importance: Undecided → Wishlist
status: New → Confirmed
Revision history for this message
Etienne Hirt (hirt) wrote :

Dear Stuart,

Here is the patch for the bug reported by Julien. It goes with our extension in https://code.launchpad.net/~vrt-openerp/openobject-addons/6.1-trunk-bug-923440

Etienne

Revision history for this message
Amit Parik (amit-parik) wrote :

Hello Stuart,

We have already removed base_contact module from trunk. So this feature can
not be consider anymore for trunk.
So you issue is only affected to 6.1 stable version.

As our stable version's policy, We have consider only blocking issue and small bug fixes (because partner
are used their production database on stable version, If we done a big
commit as a improvement then many problem will occurs on their
production database).

For 6.1 it's big improvement.
So we can not consider this improvement for stable 6.1.

Anyways thanks for contributions.

Hope you will understand this procedure.

Thanks again!

Changed in openobject-addons:
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.