[UIFe] Use the string literals that have been stated by design
Bug #937905 reported by
Manuel de la Peña
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | ||
|---|---|---|---|---|---|---|
| Ubuntu Single Sign On Client | Status tracked in Trunk | |||||
| Stable-3-0 |
Fix Released
|
Undecided
|
Unassigned | |||
| Trunk |
Fix Released
|
Medium
|
Manuel de la Peña | |||
| ubuntu-sso-client (Ubuntu) |
Fix Released
|
Undecided
|
Unassigned | |||
| Precise |
Fix Released
|
Undecided
|
Unassigned | |||
Bug Description
After talking with the design team we have noticed that the strings used in the proxy creds dialog have to be changed so that the dialog follows the standard gnome styling and clarifies what is happening to the user.
The new strings should be:
[frame title] Proxy Settings
[frame header] Please provide login details.
[connecting label] Connecting to:
[error message] Incorrect login details. Please try again.
[user label] Proxy username:
[password label] Proxy password:
[help button] Get Help With Proxies
[cancel button] Cancel
[save button] Save And Connect
Emails sent to Docs and Translators lists:
https:/
https:/
Related branches
lp:~mandel/ubuntu-sso-client/fix-credentials-text
- Roberto Alsina (community): Approve
- dobey (community): Abstain
- Natalia Bidart (community): Approve
-
Diff: 53 lines (+6/-8)2 files modifiedubuntu_sso/qt/proxy_dialog.py (+2/-2)
ubuntu_sso/utils/ui.py (+4/-6)
lp:~nataliabidart/ubuntu-sso-client/stable-3-0-update-2.99.90
- Roberto Alsina (community): Approve
-
Diff: 9631 lines (+3846/-3620)64 files modifiedbin/ubuntu-sso-proxy-creds-qt (+0/-4)
bin/ubuntu-sso-ssl-certificate-qt (+25/-0)
data/qt/choose_sign_in.ui (+0/-165)
data/qt/current_user_sign_in.ui (+163/-184)
data/qt/email_verification.ui (+105/-116)
data/qt/error_message.ui (+28/-31)
data/qt/forgotten_password.ui (+111/-188)
data/qt/loadingoverlay.ui (+3/-6)
data/qt/network_detection.ui (+139/-142)
data/qt/proxy_credentials_dialog.ui (+12/-15)
data/qt/reset_password.ui (+348/-357)
data/qt/setup_account.ui (+661/-700)
data/qt/ssl_dialog.ui (+205/-0)
data/qt/stylesheet.qss (+22/-30)
data/qt/success_message.ui (+32/-35)
run-tests.bat (+1/-1)
setup.py (+1/-0)
ubuntu_sso/credentials.py (+7/-0)
ubuntu_sso/main/glib.py (+4/-2)
ubuntu_sso/main/qt.py (+5/-3)
ubuntu_sso/networkstate/linux.py (+3/-1)
ubuntu_sso/networkstate/tests/test_linux.py (+3/-3)
ubuntu_sso/qt/__init__.py (+5/-0)
ubuntu_sso/qt/arrow.py (+68/-0)
ubuntu_sso/qt/current_user_sign_in_page.py (+32/-49)
ubuntu_sso/qt/email_verification_page.py (+39/-39)
ubuntu_sso/qt/enhanced_check_box.py (+1/-1)
ubuntu_sso/qt/error_page.py (+11/-4)
ubuntu_sso/qt/expander.py (+115/-0)
ubuntu_sso/qt/forgotten_password_page.py (+43/-113)
ubuntu_sso/qt/loadingoverlay.py (+7/-11)
ubuntu_sso/qt/main.py (+5/-0)
ubuntu_sso/qt/network_detection_page.py (+20/-9)
ubuntu_sso/qt/proxy_dialog.py (+6/-6)
ubuntu_sso/qt/reset_password_page.py (+31/-52)
ubuntu_sso/qt/setup_account_page.py (+95/-106)
ubuntu_sso/qt/sign_in_page.py (+0/-97)
ubuntu_sso/qt/ssl_dialog.py (+161/-0)
ubuntu_sso/qt/sso_wizard_page.py (+111/-33)
ubuntu_sso/qt/success_page.py (+13/-4)
ubuntu_sso/qt/tests/__init__.py (+160/-45)
ubuntu_sso/qt/tests/test_arrow.py (+90/-0)
ubuntu_sso/qt/tests/test_current_user_sign_in_page.py (+53/-143)
ubuntu_sso/qt/tests/test_email_verification.py (+34/-90)
ubuntu_sso/qt/tests/test_enchanced_line_edit.py (+2/-5)
ubuntu_sso/qt/tests/test_error_page.py (+26/-0)
ubuntu_sso/qt/tests/test_expander.py (+119/-0)
ubuntu_sso/qt/tests/test_forgotten_password.py (+38/-181)
ubuntu_sso/qt/tests/test_loadingoverlay.py (+8/-8)
ubuntu_sso/qt/tests/test_network_detection.py (+14/-34)
ubuntu_sso/qt/tests/test_reset_password.py (+25/-52)
ubuntu_sso/qt/tests/test_setup_account.py (+55/-105)
ubuntu_sso/qt/tests/test_sign_in_page.py (+0/-69)
ubuntu_sso/qt/tests/test_ssl_dialog.py (+199/-0)
ubuntu_sso/qt/tests/test_sso_wizard_page.py (+61/-97)
ubuntu_sso/qt/tests/test_success_page.py (+26/-0)
ubuntu_sso/qt/tests/test_ubuntu_sso_wizard.py (+91/-37)
ubuntu_sso/qt/ubuntu_sso_wizard.py (+95/-191)
ubuntu_sso/tests/test_credentials.py (+35/-6)
ubuntu_sso/utils/runner/__init__.py (+7/-9)
ubuntu_sso/utils/runner/tests/test_glib.py (+0/-1)
ubuntu_sso/utils/runner/tests/test_qt.py (+0/-1)
ubuntu_sso/utils/runner/tests/test_runner.py (+3/-2)
ubuntu_sso/utils/ui.py (+64/-37)
- Ubuntu One hackers: Pending requested
-
Diff: 12 lines (+1/-1)1 file modifiedsetup.py (+1/-1)
Revision history for this message
| Natalia Bidart (nataliabidart) wrote | #1 |
| summary: |
- Use the string literals that have been stated by design + [UIFe] Use the string literals that have been stated by design |
| description: | updated |
| tags: | added: u1-proxy-uife |
| tags: | added: u1-fe |
| description: | updated |
Revision history for this message
| Martin Pitt (pitti) wrote | #2 |
| Changed in ubuntu-sso-client (Ubuntu Precise): | |
| status: | New → Confirmed |
| Changed in ubuntu-sso-client: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Launchpad Janitor (janitor) wrote | #3 |
| Changed in ubuntu-sso-client (Ubuntu Precise): | |
| status: | Confirmed → Fix Released |
To post a comment you must log in.
Manuel,
Since this is a public bug, please do not link private documents that can't be seen outside canonical employees. Can you please add sreenshots of the new screens instead?
Also, string changes can not be done without an UIFe at this point, so please add the details to this bug report so we can start the process of asking for a UI freeze exception, and please ping Joshua Hoover about this.
Thanks a lot!