Pressing Ctrl+Enter in qshelve message box leads to Traceback

Bug #936982 reported by Alexander Belchenko
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
QBzr
Fix Released
Medium
IWATA Hidetaka

Bug Description

bzr: ERROR: exceptions.AttributeError: 'ShelveWidget' object has no attribute 'do_accept'

Traceback (most recent call last):
  File "C:\work\Bazaar\plugins\qbzr\lib\commit.py", line 95, in keyPressEvent
AttributeError: 'ShelveWidget' object has no attribute 'do_accept'

bzr 2.4.2 on python 2.6.6 (win32)
arguments: ['C:\\Program Files\\Bazaar\\bzr.EXE', 'qshelve']
encoding: 'cp1251', fsenc: 'mbcs', lang: None
plugins:
  acad C:\work\Bazaar\plugins\acad [0.8.0]
  bzrtools C:\Program Files\Bazaar\plugins\bzrtools [2.4.1]
  changelog_merge C:\Program Files\Bazaar\plugins\changelog_merge [2.4.2]
  colo C:\work\Bazaar\plugins\colo [0.3.1dev]
  explorer C:\work\Bazaar\plugins\explorer [1.2.2dev]
  find_branches C:\work\Bazaar\plugins\find_branches [unknown]
  format1 C:\work\Bazaar\plugins\format1 [unknown]
  launchpad C:\Program Files\Bazaar\plugins\launchpad [2.4.2]
  qbzr C:\work\Bazaar\plugins\qbzr [0.22.1dev]
  rewrite C:\Program Files\Bazaar\plugins\rewrite [0.6.3dev]
  scmproj C:\work\Bazaar\plugins\scmproj [0.6.2dev]
  svn C:\Program Files\Bazaar\plugins\svn [1.1.0]
  tiplog C:\work\Bazaar\plugins\tiplog [0.0.5dev]
  undelete C:\work\Bazaar\plugins\undelete [0.2.0]
  x_bit C:\work\Bazaar\plugins\x_bit [1.0.0]

Tags: qshelve

Related branches

Revision history for this message
Alexander Belchenko (bialix) wrote :

@Hidetaka, it seems you have used some code from qcommit, but didn't handle Ctrl+Enter at all. Either Ctrl+Enter should be disabled, or proper support (run shelve) should be implemented.

Changed in qbzr:
assignee: nobody → IWATA Hidetaka (hid-iwata)
Revision history for this message
IWATA Hidetaka (hid-iwata) wrote :

@Alexander
I've fixed this and made merge-proposal against lp:qbzr/0.22
Please check it out.

Changed in qbzr:
milestone: none → 0.22.2
status: Confirmed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.