Launchpad itself

Update bug to use information_visibility_policy

Bug #933766 reported by Curtis Hovey
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Launchpad itself
Fix Released
High
Steve Kowalik

Bug Description

Once the schema is available to access information_visibility_policies, the models should use the new attr, but failover to reading the old values. The security and private attrs should return the calculated value from the enum to preserve the old API. Setting a value will update information_visibility_policies.

Related branches

lp:~stevenk/launchpad/information_type-model
William Grant: Approve (code)
Diff: 0 lines
lp:~stevenk/launchpad/information_type-bugs-garbo
Ian Booth (community): Approve
Diff: 74 lines (+35/-0)
3 files modified
lib/lp/bugs/model/tests/test_bug.py (+2/-0)
lib/lp/scripts/garbo.py (+23/-0)
lib/lp/scripts/tests/test_garbo.py (+10/-0)
lp:~stevenk/launchpad/bugs-use-information_type
William Grant: Approve (code)
Diff: 0 lines
lp:~stevenk/launchpad/db-bug-information_type-not-null
Stuart Bishop (community): Approve (db)
Robert Collins: Pending (db) requested
Diff: 13 lines (+9/-0)
1 file modified
database/schema/patch-2209-12-2.sql (+9/-0)
lp:~stevenk/launchpad/db-triggers-information_type
Stuart Bishop (community): Approve (db)
Robert Collins: Pending (db) requested
Diff: 120 lines (+116/-0)
1 file modified
database/schema/patch-2209-12-3.sql (+116/-0)
lp:~stevenk/launchpad/bugs-remove-old-privacy
Ian Booth (community): Approve
Diff: 1202 lines (+232/-232)
21 files modified
lib/lp/bugs/browser/bug.py (+8/-5)
lib/lp/bugs/browser/bugtarget.py (+8/-5)
lib/lp/bugs/doc/bug-private-by-default.txt (+2/-1)
lib/lp/bugs/doc/bug.txt (+5/-2)
lib/lp/bugs/doc/bugnotification-sending.txt (+2/-1)
lib/lp/bugs/doc/bugsubscription.txt (+4/-3)
lib/lp/bugs/doc/security-teams.txt (+8/-7)
lib/lp/bugs/interfaces/bug.py (+10/-15)
lib/lp/bugs/mail/commands.py (+10/-8)
lib/lp/bugs/mail/tests/test_commands.py (+10/-6)
lib/lp/bugs/model/bug.py (+91/-128)
lib/lp/bugs/model/bugtask.py (+3/-3)
lib/lp/bugs/model/tests/test_bug.py (+23/-26)
lib/lp/bugs/scripts/bugimport.py (+8/-8)
lib/lp/bugs/stories/bugs/xx-bug-activity.txt (+6/-0)
lib/lp/bugs/xmlrpc/bug.py (+11/-7)
lib/lp/registry/enums.py (+5/-0)
lib/lp/registry/model/person.py (+5/-2)
lib/lp/security.py (+3/-1)
lib/lp/systemhomes.py (+5/-2)
lib/lp/testing/factory.py (+5/-2)
lp:~stevenk/launchpad/information_type-vocab
William Grant: Approve (code)
Diff: 266 lines (+162/-3)
6 files modified
lib/lp/bugs/browser/bug.py (+27/-1)
lib/lp/bugs/browser/tests/test_bugview.py (+20/-1)
lib/lp/registry/tests/test_information_type_vocabulary.py (+65/-0)
lib/lp/registry/vocabularies.py (+31/-0)
lib/lp/registry/vocabularies.zcml (+7/-1)
lib/lp/services/features/flags.py (+12/-0)
lp:~stevenk/launchpad/bugs-information_type-ui-secrecy
Ian Booth (community): Approve
Diff: 219 lines (+103/-26)
5 files modified
lib/lp/bugs/browser/bug.py (+59/-25)
lib/lp/bugs/browser/tests/test_bug_views.py (+33/-0)
lib/lp/bugs/interfaces/bug.py (+1/-1)
lib/lp/registry/vocabularies.py (+3/-0)
lib/lp/services/features/flags.py (+7/-0)
lp:~stevenk/launchpad/bugs-information_type-ui-filebug
j.c.sackett (community): Approve
Richard Harding (community): Approve (code*)
Diff: 436 lines (+198/-47)
4 files modified
lib/lp/bugs/browser/bugtarget.py (+86/-31)
lib/lp/bugs/browser/tests/test_bugtarget_filebug.py (+67/-2)
lib/lp/bugs/templates/bugtarget-filebug-guidelines.pt (+12/-0)
lib/lp/bugs/templates/bugtarget-macros-filebug.pt (+33/-14)
lp:~stevenk/launchpad/bugs-information_type-ui-portlet
Ian Booth (community): Approve
Diff: 419 lines (+312/-22)
7 files modified
lib/lp/bugs/browser/bug.py (+9/-2)
lib/lp/bugs/browser/tests/test_bugview.py (+17/-0)
lib/lp/bugs/javascript/bugtask_index.js (+6/-2)
lib/lp/bugs/javascript/information_type_choice.js (+69/-0)
lib/lp/bugs/javascript/tests/test_information_type_choice.html (+80/-0)
lib/lp/bugs/javascript/tests/test_information_type_choice.js (+106/-0)
lib/lp/bugs/templates/bug-portlet-privacy.pt (+25/-18)
lp:~stevenk/launchpad/bugdelta-information_type
Ian Booth (community): Approve
Diff: 348 lines (+147/-31)
7 files modified
lib/lp/bugs/adapters/bugchange.py (+41/-5)
lib/lp/bugs/adapters/bugdelta.py (+5/-4)
lib/lp/bugs/browser/bugtask.py (+1/-1)
lib/lp/bugs/interfaces/bug.py (+4/-2)
lib/lp/bugs/stories/bugs/xx-bug-activity.txt (+18/-0)
lib/lp/bugs/subscribers/bug.py (+10/-4)
lib/lp/bugs/tests/test_bugchanges.py (+68/-15)
lp:~stevenk/launchpad/bugs-information_type-mail
William Grant: Approve (code)
Diff: 148 lines (+96/-0)
3 files modified
lib/lp/bugs/mail/commands.py (+26/-0)
lib/lp/bugs/mail/tests/test_commands.py (+52/-0)
lib/lp/bugs/mail/tests/test_handler.py (+18/-0)
lp:~stevenk/launchpad/information_type-notification-flag
William Grant: Approve (code)
Diff: 127 lines (+35/-10)
5 files modified
lib/lp/bugs/adapters/bugchange.py (+3/-3)
lib/lp/bugs/stories/bugs/xx-bug-activity.txt (+21/-3)
lib/lp/bugs/subscribers/bug.py (+1/-1)
lib/lp/bugs/tests/test_bugchanges.py (+3/-3)
lib/lp/services/features/flags.py (+7/-0)
lp:~stevenk/launchpad/destroy-old-privacy-ui
Ian Booth (community): Approve
Diff: 1619 lines (+126/-616)
33 files modified
database/sampledata/current-dev.sql (+0/-1)
lib/lp/app/browser/informationtype.py (+0/-6)
lib/lp/bugs/browser/bug.py (+8/-105)
lib/lp/bugs/browser/bugtarget.py (+18/-58)
lib/lp/bugs/browser/bugtask.py (+3/-7)
lib/lp/bugs/browser/tests/bugtarget-filebug-views.txt (+4/-6)
lib/lp/bugs/browser/tests/test_bug_views.py (+8/-65)
lib/lp/bugs/browser/tests/test_bugtarget_filebug.py (+16/-26)
lib/lp/bugs/browser/tests/test_bugtask.py (+3/-5)
lib/lp/bugs/javascript/bugtask_index.js (+1/-43)
lib/lp/bugs/javascript/filebug.js (+1/-20)
lib/lp/bugs/javascript/information_type_choice.js (+1/-6)
lib/lp/bugs/javascript/tests/test_filebug.js (+0/-5)
lib/lp/bugs/javascript/tests/test_information_type_choice.js (+0/-1)
lib/lp/bugs/stories/bug-also-affects/xx-also-affects-upstream-private-bug.txt (+1/-6)
lib/lp/bugs/stories/bug-privacy/xx-bug-privacy.txt (+4/-20)
lib/lp/bugs/stories/bug-privacy/xx-presenting-private-bugs.txt (+6/-8)
lib/lp/bugs/stories/bugs/xx-bug-activity.txt (+6/-19)
lib/lp/bugs/stories/bugs/xx-duplicate-of-private-bug.txt (+2/-3)
lib/lp/bugs/stories/bugtracker/xx-bugtracker-remote-bug.txt (+4/-10)
lib/lp/bugs/stories/bugtracker/xx-bugtracker.txt (+3/-4)
lib/lp/bugs/stories/initial-bug-contacts/xx-initial-bug-contacts.txt (+2/-4)
lib/lp/bugs/stories/upstream-bugprivacy/xx-upstream-bug-privacy.txt (+2/-16)
lib/lp/bugs/templates/bug-portlet-privacy.pt (+0/-22)
lib/lp/bugs/templates/bugtarget-filebug-guidelines.pt (+0/-39)
lib/lp/code/browser/branch.py (+3/-34)
lib/lp/code/browser/tests/test_branch.py (+14/-24)
lib/lp/code/stories/branches/xx-branch-edit-privacy.txt (+10/-20)
lib/lp/code/stories/branches/xx-branch-index.txt (+1/-1)
lib/lp/code/stories/branches/xx-branch-listings.txt (+2/-3)
lib/lp/code/stories/branches/xx-bug-branch-links.txt (+3/-4)
lib/lp/code/templates/branch-portlet-privacy.pt (+0/-12)
lib/lp/services/features/flags.py (+0/-13)
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r14943 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14943) is part of this bug's fix.

Changed in launchpad:
assignee: nobody → Steve Kowalik (stevenk)
tags: added: qa-needstesting
Changed in launchpad:
status: Triaged → In Progress
Steve Kowalik (stevenk)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r14944 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14944) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Steve Kowalik (stevenk)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r14986 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/14986) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Steve Kowalik (stevenk)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r11467 in db-stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/11467) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
William Grant (wgrant)
tags: added: bad-commit-14986
Steve Kowalik (stevenk)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r11483 in db-stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/db-stable/revision/11483) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Steve Kowalik (stevenk)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r15038 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15038) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Steve Kowalik (stevenk)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r15078 (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15078) by a commit, but not testable.

tags: added: qa-untestable
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Steve Kowalik (stevenk)
Changed in launchpad:
status: Fix Committed → In Progress
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r15123 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15123) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-untestable
Steve Kowalik (stevenk)
tags: added: qa-untestable
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r15130 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15130) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-untestable
Steve Kowalik (stevenk)
tags: added: qa-untestable
removed: qa-needstesting
Curtis Hovey (sinzui)
tags: added: information-type
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r15141 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15141) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-untestable
Steve Kowalik (stevenk)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r15173 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15173) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Steve Kowalik (stevenk)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r15201 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15201) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Steve Kowalik (stevenk)
tags: added: qa-ok
removed: qa-needstesting
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

r15213 in stable (http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15213) is part of this bug's fix.

tags: added: qa-needstesting
removed: qa-ok
Steve Kowalik (stevenk)
tags: added: qa-ok
removed: qa-needstesting
Curtis Hovey (sinzui)
tags: added: privacy
Revision history for this message
Launchpad QA Bot (lpqabot) wrote :

Fixed in stable r15494 <http://bazaar.launchpad.net/~launchpad-pqm/launchpad/stable/revision/15494>.

tags: added: qa-needstesting
removed: qa-ok
Changed in launchpad:
status: In Progress → Fix Committed
Steve Kowalik (stevenk)
tags: added: qa-ok
removed: qa-needstesting
William Grant (wgrant)
Changed in launchpad:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.