Ubuntu
command-not-found package

No zsh support (debdiff attached)

Bug #92942 reported by Johan Kiviniemi
4
Affects Status Importance Assigned to Milestone
command-not-found (Ubuntu)
Fix Released
Undecided
Michael Vogt

Bug Description

Binary package hint: command-not-found

command-not-found doesn't support zsh. A debdiff that fixes that is attached.

Revision history for this message
Johan Kiviniemi (ion) wrote :
Revision history for this message
Michael Vogt (mvo) wrote :

Thanks for your patch!

It is merged into my command-not-found tree and will be part of the next upload.

Cheers,
 Michael

Changed in command-not-found:
assignee: nobody → mvo
status: Unconfirmed → Fix Committed
Revision history for this message
Chris Ball (chris-ubuntu) wrote :

You should add a "unset command" after the whence line, else an empty line after the line that caused a suggestion will repeat the suggestion due to command still being set.

I think it's also a serious bug that you're overwriting precmd() -- my precmd sets my prompt, for example.

Thanks for the patch, though. ;-) I'm running it here.

Revision history for this message
Johan Kiviniemi (ion) wrote :

I've added 'unset command' to my bzr branch. The change will probably be part of the next upload. Thanks for the suggestion.

I'd be thankful if you found a way to implement it without overwriting precmd. Ideas are welcome. :-)

Revision history for this message
Johan Kiviniemi (ion) wrote :

command-not-found (0.2.4) feisty; urgency=low

  [ Michael Vogt ]
  * remove support for suggestins.d/ dir (not used currently and
    may break stuff)

  [ Zygmunt Krynicki ]
  * Fixed launchpad #95794: warning emitted about not finding group name
  * data files updated

  [ Johan Kiviniemi ]
  * zsh_command_not_found: unset the command variable, otherwise an empty
    line will rerun command-not-found. Thanks to Chris Ball for suggesting
    this (LP: #92942).

Changed in command-not-found:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.