Possibly wrong posix_fadvise hints
Bug #925441 reported by
Laurynas Biveinis
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona XtraBackup moved to https://jira.percona.com/projects/PXB |
Fix Released
|
Low
|
Alexey Kopytov | ||
| 2.0 |
Fix Released
|
Low
|
Alexey Kopytov | ||
Bug Description
posix_fadvise usage in XtraBackup sources have to be audited. Superficially at least some of them look wrong, i.e. POSIX_FADV_DONTNEED before file access.
Related branches
lp:~akopytov/percona-xtrabackup/bug925441
- Stewart Smith (community): Approve
-
Diff: 63 lines (+13/-5)1 file modifiedsrc/xtrabackup.c (+13/-5)
| Changed in percona-xtrabackup: | |
| milestone: | none → 1.9.3 |
| assignee: | nobody → Alexey Kopytov (akopytov) |
| status: | Confirmed → In Progress |
Revision history for this message
| Alexey Kopytov (akopytov) wrote | #1 |
| Changed in percona-xtrabackup: | |
| status: | In Progress → Fix Committed |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #2 |
To post a comment you must log in.
The problem was that posix_fadvise(
incorrectly, because the call just releases already cached pages from
the pagecache, thus making a single-shot call before file access
useless.
Fixed by making sure the call is invoked after each read/write to
make the feature work as advertised.