Ubuntu
pkgbinarymangler package

pkgstripfiles: md5sum incorrect when advpng fails

Bug #923407 reported by Felix Geyer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pkgbinarymangler (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

The md5sum is not updated when advpng fails but optipng ran fine.

This happened with the gquilt 0.25-2 package:
Unexpected PLTE chunk on ./usr/share/pixmaps/gquilt/stock_finish.png [at void throw_png_error():pngex.h:37]
WARNING: advpng failed on ./usr/share/pixmaps/gquilt/stock_finish.png, ignoring

Then lintian says:
E: gquilt: md5sum-mismatch usr/share/pixmaps/gquilt/stock_finish.png

> if ! optipng -o4 -preserve "$f"; then
> echo "WARNING: optipng failed on $f, ignoring" >&2
> continue
> fi
> if ! advpng -z4 "$f"; then
> echo "WARNING: advpng failed on $f, ignoring" >&2
> continue
> fi

The second continue statement needs to be removed.
I'm not sure why the first one is there, mabye both should be removed.

Revision history for this message
Martin Pitt (pitti) wrote :

Thanks! Indeed they should both be removed, there is no reason that advpng should be skipped if optipng fails.

Changed in pkgbinarymangler (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pkgbinarymangler - 114

---------------
pkgbinarymangler (114) precise; urgency=low

  [ Felix Geyer ]
  * pkgstripfiles, symlink_doc(): Don't create symlinks that would point to
    the same package. (LP: #923343)
  * test/run: Add test_doc_symlink_dependency_cycle() to make sure that
    pkgstripfiles works correctly when there is a dependency cycle inside
    a source package.

  [ Martin Pitt ]
  * pkgstripfiles: Always update md5sum even if advpng fails. Also call advpng
    if optipng fails, to at least get some optimization. Thanks Felix Geyer!
    (LP: #923407)
  * pkgstripfiles: Do not truncate changelogs when they are in a different
    directory pointed to a symlink. Add corresponding test case which mimics
    the perl hack that it applies to its doc files. (LP: #923430)
 -- Martin Pitt <email address hidden> Fri, 03 Feb 2012 06:36:35 +0100

Changed in pkgbinarymangler (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.