pkgstripfiles: creates symlinks that point to themselves

Bug #923343 reported by Felix Geyer
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pkgbinarymangler (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

pkgstripfiles/symlink_doc() creates symlinks that point to themselves if there are cyclic dependencies inside a package.

For example in qt4-x11:
> pkgstripfiles: processing control file: debian/qdbus/DEBIAN/control, package qdbus, directory debian/qdbus
> .. removing usr/share/doc/qdbus/changelog.gz
> Searching for duplicated docs in dependency libqt4-dbus...
> symlinking LGPL_EXCEPTION.txt in qdbus to file in qdbus
> symlinking changelog.Debian.gz in qdbus to file in qdbus

which results in ./usr/share/doc/qdbus/LGPL_EXCEPTION.txt -> ../qdbus/LGPL_EXCEPTION.txt

http://lintian.ubuntuwire.org/tags/lengthy-symlink.html has some more examples.

Related branches

Martin Pitt (pitti)
Changed in pkgbinarymangler (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pkgbinarymangler - 114

---------------
pkgbinarymangler (114) precise; urgency=low

  [ Felix Geyer ]
  * pkgstripfiles, symlink_doc(): Don't create symlinks that would point to
    the same package. (LP: #923343)
  * test/run: Add test_doc_symlink_dependency_cycle() to make sure that
    pkgstripfiles works correctly when there is a dependency cycle inside
    a source package.

  [ Martin Pitt ]
  * pkgstripfiles: Always update md5sum even if advpng fails. Also call advpng
    if optipng fails, to at least get some optimization. Thanks Felix Geyer!
    (LP: #923407)
  * pkgstripfiles: Do not truncate changelogs when they are in a different
    directory pointed to a symlink. Add corresponding test case which mimics
    the perl hack that it applies to its doc files. (LP: #923430)
 -- Martin Pitt <email address hidden> Fri, 03 Feb 2012 06:36:35 +0100

Changed in pkgbinarymangler (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.