Odoo Addons (MOVED TO GITHUB)

Project and analytic account partner address label

Bug #918642 reported by Stefan Rijnhart (Opener)
10
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
OpenERP R&D Addons Team 1

Bug Description

Hi,

There is a field on project.project, with name 'contact_id'. The label on the project form (tab Billing) for this partner address is 'Invoice address'. Due to _inherit, this field also exists on the analytic account. Here it is called 'Contact'. The on_change method on the partner_id automatically selects the partner's address of type 'contact' if it exists.

The address selected here does not seem to affect the addresses on the generated invoices, as they select the invoice and contact addresses independent of this setting.

We find it confusing that the address on the project is called 'Invoice address' but the invoice address is not selected. Please change the label to reflect the type of address.

Cheers,
Stefan.

Related branches

lp:~openerp-dev/openobject-addons/trunk-bug-918642-kjo
Raphael Collet (OpenERP) (community): Approve
Stefan Rijnhart (Opener) (community): Approve
Kuldeep Joshi(OpenERP) (community): Needs Resubmitting
Bhumika Shrimali: Pending requested
Diff: 12 lines (+1/-1)
1 file modified
project/project_view.xml (+1/-1)
Revision history for this message
Jignesh Rathod(OpenERP) (jir-openerp) wrote :

Hello ,

I have check this issue at my end with trunk.

As per my opinion analytic and project both should be a
display Invoice address.

For analytic there should be a label "Invoice Address" not "Contact Address"
and for Project address should be a Invoice address not contact address so we should
be change type of the address.

For this generalise issue I have assign to only one team "Addons1" .

Let the respective team to decide.

Thanks.

Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 1 (openerp-dev-addons1)
importance: Undecided → Low
status: New → Confirmed
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Hi Jignesh,

thank you for your reaction. The situation is even more ambiguous than I thought. Have a look at analytic/analytic.py. You will see two on change methods defined on class account_analytic_account:

onchange_partner_id: selects the invoice address
on_change_partner_id: selects the contact address

It is the latter one that is actually used, in account/project/project_view.

By the looks of it, the 'contact_id' address field itself is hardly used anywhere either in project or analytic, although there is a reference to it in the context of the sale order's project id. Here, it is assigned the value of the ordering *contact* of the partner (see sale/sale_view.xml).

I remain that the label should change to 'Contact address' and am curious to hear the Addons1 team's opinion.

Cheers,
Stefan.

Kuldeep Joshi(OpenERP) (kjo-openerp)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
Kuldeep Joshi(OpenERP) (kjo-openerp) wrote :

Hello, Thanks For Reporting.
It has been Fixed in https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-918642-kjo
revision-id: <email address hidden>
revno: 6367
It will be available in trunk soon.

Changed in openobject-addons:
status: In Progress → Fix Committed
Revision history for this message
Kuldeep Joshi(OpenERP) (kjo-openerp) wrote :

I am not change the Invoice Address label of Billing tab because if install the project_timesheet module it create invoice for the task and at that time this Invoice Address filed is use as customer address.

I hope it is help you to understand

Thank you

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Hi Kuldeep

what you say does not appear to be the case. The module that actually creates the invoice is "hr_timesheet_invoice", and it does not use contact_id. Instead, this module calls address_get(['invoice']) on the partner directly (in hr_timesheet_invoice/wizard/hr_timesheet_invoice_create.py, line 85).

Can you point out where the contact_id is actually used?

Cheers,
Stefan.

Revision history for this message
Raphael Collet (OpenERP) (rco-openerp) wrote :

merged in trunk
revno: 6414 [merge]
revision-id: <email address hidden>

Changed in openobject-addons:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.