"Preview Diff" on code review pages lacks the "Show diffs side-by-side" option
Bug #917502 reported by
Daniel van Vugt
This bug affects 5 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Launchpad itself |
Fix Released
|
Low
|
Colin Watson | ||
Bug Description
When browsing code on bazaar.
This option would be most useful in code reviews / merge proposals, however the option is not available in the Preview Diff of a code review. Why not?...
Related branches
lp:~cjwatson/launchpad/side-by-side-diff
- William Grant: Approve (code)
-
Diff: 811 lines (+504/-65)11 files modifiedlib/canonical/launchpad/icing/css/modifiers.css (+1/-1)
lib/canonical/launchpad/icing/style.css (+4/-2)
lib/lp/app/browser/stringformatter.py (+153/-33)
lib/lp/app/browser/tests/test_stringformatter.py (+292/-13)
lib/lp/code/javascript/branchmergeproposal.inlinecomments.js (+15/-3)
lib/lp/code/javascript/branchmergeproposal.reviewcomment.js (+12/-8)
lib/lp/code/stories/branches/xx-branchmergeproposals.txt (+1/-1)
lib/lp/code/templates/branchmergeproposal-diff.pt (+10/-1)
lib/lp/code/templates/codereviewcomment-body.pt (+6/-1)
lib/lp/code/templates/codereviewnewrevisions-footer.pt (+6/-1)
lib/lp/services/features/templates/feature-changelog.pt (+4/-1)
| Changed in launchpad: | |
| status: | New → Triaged |
| importance: | Undecided → Low |
| tags: | added: code-review |
| Changed in launchpad: | |
| assignee: | nobody → Colin Watson (cjwatson) |
| status: | Triaged → In Progress |
Revision history for this message
| Launchpad QA Bot (lpqabot) wrote | #1 |
| tags: | added: qa-needstesting |
| Changed in launchpad: | |
| status: | In Progress → Fix Committed |
| tags: |
added: qa-ok removed: qa-needstesting |
| Changed in launchpad: | |
| status: | Fix Committed → Fix Released |
To post a comment you must log in.
Fixed in stable r17584 <http://