woverview.cpp update() called in a hight frequency

Bug #914203 reported by Daniel Lindenfelser
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Mixxx
Fix Released
Medium
Daniel Lindenfelser

Bug Description

woverview.cpp:170

check for real view changes here this const much less cpu as update the view every time

iPos = (int)(((fValue-14.)/100.)*((double)width()-2.));
if (iPos != m_iPos) {
    m_iPos = iPos;
    update();
}

Tags: performance
Revision history for this message
RJ Skerry-Ryan (rryan) wrote :

Looks good to me.

tags: added: performance
Changed in mixxx:
status: New → Confirmed
milestone: none → 1.10.1
importance: Undecided → Medium
assignee: nobody → Daniel Lindenfelser (dan-lin)
status: Confirmed → In Progress
Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → In Progress
RJ Skerry-Ryan (rryan)
Changed in mixxx:
milestone: 1.10.1 → 1.11.0
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: In Progress → Fix Committed
RJ Skerry-Ryan (rryan)
Changed in mixxx:
status: Fix Committed → Fix Released
Revision history for this message
Swiftb0y (swiftb0y) wrote :

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6239

lock status: Metadata changes locked and limited to project staff
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.