rev 752 breaks ipython.el, py-mode-map missed

Am 06.01.2012 21:57, schrieb Thomas Caswell:
> Public bug reported:
>
> Changing py-mode-map to python-mode-map broke ipython. I have added a
> hacky fix to their tracking.
>
> https://github.com/ipython/ipython/pull/1242
>

Hi,

need some recipe to reproduce.
Completion in IPython works fine here with TAB.

Did you patch against current trunk?

BTW have a look at

defcustom py-complete-function

thanks,

Andreas

When I switch to python-mode I get the error:

File mode specification error: (void-variable py-mode-map)

The change in 752 was renaming py-mode-map to python-mode-map. The change to ipython.el is the matching rename.

Sorry for the poor bug report.

I was using the latest trunk/master for both python-mode and ipython

Am 09.01.2012 19:45, schrieb Thomas Caswell:
> I was using the latest trunk/master for both python-mode and ipython
>

still need some description how the bug is triggered.

Please send output from M-x report-emacs-bug when bug occurs.

thanks,

Andreas

This bug report will be sent to the Bug-GNU-Emacs mailing list
and the GNU bug tracker at debbugs.gnu.org. Please check that
the From: line contains a valid email address. After a delay of up
to one day, you should receive an acknowledgement at that address.

Please write in English if possible, as the Emacs maintainers
usually do not have translators for other languages.

Please describe exactly what actions triggered the bug, and
the precise symptoms of the bug. If you can, give a recipe
starting from `emacs -Q':

$ emacs -Q

;; to get ipython.el in the path
(add-to-list 'load-path "~/.emacs.d")
;; to get the trunk version of python-mode in the path
(setq load-path (append load-path (list "~/.emacs.d/python-mode")))
(require 'python)
(require 'ipython)

;; open (or reload) a .py file to trigger switching to python-mode

If Emacs crashed, and you have the Emacs process in the gdb debugger,
please include the output from the following gdb commands:
    `bt full' and `xbacktrace'.
For information about debugging Emacs, please read the file
/home/tcaswell/local_installs/share/emacs/24.0.92/etc/DEBUG.

In GNU Emacs 24.0.92.1 (x86_64-unknown-linux-gnu, X toolkit)
 of 2012-01-04 on innoue
Windowing system distributor `The X.Org Foundation', version 11.0.11102902
configured using `configure '--prefix=/home/tcaswell/local_installs' '--with-gif=no' '--with-x-toolkit=lucid''

Important settings:
  value of $LC_ALL: nil
  value of $LC_COLLATE: nil
  value of $LC_CTYPE: nil
  value of $LC_MESSAGES: nil
  value of $LC_MONETARY: nil
  value of $LC_NUMERIC: nil
  value of $LC_TIME: nil
  value of $LANG: en_US
  value of $XMODIFIERS: nil
  locale-coding-system: iso-latin-1-unix
  default enable-multibyte-characters: t

Major mode: Python

Minor modes in effect:
  shell-dirtrack-mode: t
  tooltip-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Recent input:
C-x C-f p y <tab> l <tab> i <tab> g <tab> o <tab> .
<tab> <return> M-x m e <tab> s <tab> <M-backspace>
<escape> <escape> <escape> C-x b m e s <tab> <M-backspace>
C-g M-x p y - s h e l l <return> <C-backspace> <M-backspace>
C-g C-g C-x C-f <M-backspace> <M-backspace> . e m <tab>
<return> <down> <down> <down> <down> <down> <end> C-x
C-e C-x b <return> C-x C-v <return> C-x b <return>
C-s p y t h o n <down> <down> <down> <up> <end> C-x
C-e <down> C-x C-e <down> <end> C-x C-e C-x b <return>
C-x C-v <return> M-x r e p o <tab> r <tab> <return
>

Recent messages:
Loading vc-git...done
Making completion list...
Quit [4 times]
("~/.emacs.d" "/home/tcaswell/local_installs/share/emacs/24.0.92/site-lisp" "/home/tcaswell/local_installs/share/emacs/site-lisp" "/home/tcaswell/local_installs/share/emacs/site-lisp/a2ps" "/home/tcaswell/local_installs/share/emacs/site-lisp/apel" "/home/tcaswell/local_installs/share/emacs/site-lisp/auctex" "/home/tcaswell/local_installs/share/emacs/site-lisp/autoconf" "/home/tcaswell/local_installs/share/emacs/site-lisp/bitmap-mule" "...

subsequent attempts to use py-execute-buffer give the error:

ipython-shell-hook: Symbol's value as variable is void: py-mode-map

and nothing is executed.

I also noticed that the above recipe launches an IPython session on it's own. I am not sure if that is the intended behavior.

Am 09.01.2012 22:11, schrieb Thomas Caswell:
> This bug report will be sent to the Bug-GNU-Emacs mailing list
> and the GNU bug tracker at debbugs.gnu.org. Please check that
> the From: line contains a valid email address. After a delay of up
> to one day, you should receive an acknowledgement at that address.
>
> Please write in English if possible, as the Emacs maintainers
> usually do not have translators for other languages.
>
> Please describe exactly what actions triggered the bug, and
> the precise symptoms of the bug. If you can, give a recipe
> starting from `emacs -Q':
>
> $ emacs -Q
>
> ;; to get ipython.el in the path
> (add-to-list 'load-path "~/.emacs.d")
> ;; to get the trunk version of python-mode in the path
> (setq load-path (append load-path (list "~/.emacs.d/python-mode")))
> (require 'python)
> (require 'ipython)
>

hmm, ipython.el is no longer needed.

Just don't load it for the moment.

Should we re-install py-mode-map in order to provide backward
compatibility, serve existing customizations?

CC to Barry,

thanks for the report,

Andreas

BTW, I'm just looking at this bug because it affects me too. Renaming py-mode-map to python-mode-map broke my customizations. I'm willing to change them though.

being well aware of the set-backs
a couple of bugs are gone now

made up a new branch py-mode-map

    `python-mode-map' replaced by `py-mode-map' again

    this doesn't make the key for
     [(control c)(control n)] 'py-end-of-statement)

    for example

    any ideas why?

Am 10.03.2012 22:38, schrieb Ulrich Müller:
> ** Bug watch added: Gentoo Bugzilla #407715
> http://bugs.gentoo.org/show_bug.cgi?id=407715
>
> ** Also affects: gentoo via
> http://bugs.gentoo.org/show_bug.cgi?id=407715
> Importance: Unknown
> Status: Unknown
>

Hi,

inserting below definition of python-mode-map

(setq py-mode-map python-mode-map)

should fix it.

Can you try that?

Thanks,

Andreas

python-mode now provides a

(defvar py-mode-map python-mode-map)

this should do it.

Please re-open if not.

Cheers,

Andreas