Odoo Addons (MOVED TO GITHUB)

[trunk] new module account_bank_statement_extension conflicts with point_of_sale

Bug #909124 reported by Jacques-Etienne Baudoux
8
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Odoo Addons (MOVED TO GITHUB)
Fix Released
Low
OpenERP R&D Addons Team 3

Bug Description

The new module account_bank_statement_extensions coming from Noviat merge proposal is conflicting with the pre-existing point_of_sale module.

It redefining the column journal_id in the model account.bank.statement.line with a different type
account_bank_statement_extensions:
 'journal_id': fields.related('statement_id', 'journal_id', type='many2one',...)
point_of_sale:
'journal_id': fields.related('statement_id','journal_id','name', store=True, string='Journal', type='char', size=64),

Please rename that column in the account_bank_statement_extensions (and not in point_of_sale to ease migration)

kr
J-E

Related branches

lp:~openerp-dev/openobject-addons/trunk-bug-909124-mdi
Rejected for merging into lp:openobject-addons
Purnendu Singh (OpenERP) (community): Disapprove
qdp (OpenERP): Needs Fixing
Diff: 19 lines (+2/-2)
1 file modified
account_bank_statement_extensions/account_bank_statement.py (+2/-2)
lp:~openerp-dev/openobject-addons/trunk-bug-909124-new-mdi
DJ Patel (OpenERP) (community): Needs Resubmitting
qdp (OpenERP): Needs Fixing
Diff: 55 lines (+3/-4)
4 files modified
account/account_bank_statement.py (+1/-0)
account_bank_statement_extensions/account_bank_statement.py (+1/-2)
point_of_sale/point_of_sale.py (+0/-1)
point_of_sale/point_of_sale_demo.xml (+1/-1)
Revision history for this message
Jacques-Etienne Baudoux (jbaudoux) wrote :

It's like the journal_id is not used at all in account.bank.statement.line
kr
J-E

Revision history for this message
Jacques-Etienne Baudoux (jbaudoux) wrote :

It's like the journal_id is not used at all in account.bank.statement.line in the module account_bank_statement_extensions
kr
J-E

Ravish(OpenERP) (rmu-openerp)
Changed in openobject-addons:
status: New → Confirmed
Amit Parik (amit-parik)
Changed in openobject-addons:
assignee: nobody → OpenERP R&D Addons Team 3 (openerp-dev-addons3)
importance: Undecided → Low
DJ Patel (OpenERP) (mdi-openerp)
Changed in openobject-addons:
status: Confirmed → In Progress
Revision history for this message
DJ Patel (OpenERP) (mdi-openerp) wrote :

Hello Jacques-Etienne Baudoux,

Thanks for reporting. The solution for this bug is proposed in the branch : https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-909124-mdi/

with following Revision ID and Number.

Revision ID : <email address hidden>
Revision Number : 6171

Thanks and Regards,

Divyesh Makwana(MDI)

Changed in openobject-addons:
status: In Progress → Fix Committed
Revision history for this message
qdp (OpenERP) (qdp) wrote :

sorry but i disagree here: if the field duplicated has to be changed somewhere it is in point_of_sale where the naming doesn't reflect the type of the field. Rename it into journal_name.

We shouldn't go the code creepy for the sake of "easing the migrations".

Another (a best) solution is to add this field (related, many2one) in account module in order to avoid totally .duplicated fields

Changed in openobject-addons:
status: Fix Committed → In Progress
Revision history for this message
DJ Patel (OpenERP) (mdi-openerp) wrote :

Hello Jacques-Etienne Baudoux,

Thanks for reporting. The solution for this bug is proposed in the branch : https://code.launchpad.net/~openerp-dev/openobject-addons/trunk-bug-909124-new-mdi/

with following Revision ID and Number.

Revision ID : <email address hidden>
Revision Number : 6233

Thanks and Regards,

Divyesh Makwana(MDI)

DJ Patel (OpenERP) (mdi-openerp)
Changed in openobject-addons:
status: In Progress → Fix Committed
Revision history for this message
qdp (OpenERP) (qdp) wrote :

fix released in revision 6633
revision-id: <email address hidden>

Thanks

Changed in openobject-addons:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.