qt_<locale>.qm missing on Windows, translated shortcuts not working

Hmm, looks like the language setting does make a difference indeed.
Bug confirmed with Mixxx 1.10 final on WIndows XP SP3 if language is set to German.
C:\Program Files\Mixxx>mixxx.exe --locale de

other languages seems unaffected, e.g.
C:\Program Files\Mixxx>mixxx.exe --locale ru
C:\Program Files\Mixxx>mixxx.exe --locale pl
C:\Program Files\Mixxx>mixxx.exe --locale en_GB

I have tried to solve it like this:
m_pOptionsShoutcast->setShortcut(QKeySequence(tr("Ctrl+L")));
(Now waiting for Hudson ...)

I have noticed that some shortcuts have a translated modifier key "Strg" and some not "Ctrl".

I have decided to use always the native names in *.kbd.conf so what's the rule for translation?

We have to install the qt_<locale>.qm files on Windows to solve the problem.

Note:
All short-cuts in the German text resources should be translate to their native names like "Strg" and "Umschalt"

Ahh, now i understand. Apparently we allow translations for our shortcuts and "CTRL" is translated to "STRG" in our german translation (what is correct in itself).
Would be interesting to know if Linux is affected by this bug too.
Mac OS seems to be unaffected - we do not have "CTRL" there , using "Cmd" instead per QT default.

BTW.
Shortcuts in the german translations were already translated except for one element, fixed that.
If a translation is incomplete/not correct , anyone can submit translations directly to Mixxx in Launchpad as Mixxx is translated with open permissions.

There are two sources for translations: mixxx_<locale>.qm and qt_<locale>.qm. On Linux, the qt_<locale>.qm files are installed with the Qt packages. On windows, we provide the Qt dlls without the qt_<locale>.qm and that the issue.

When mixxx tries to install a short-cut for an action, e.g tr("Ctrl-L") it is translated to "Strg+L" for German locale. QT parses the text to know on which short-cut it should react. If there is no qt_de.qm loaded in this case, it does not recognise "Strg" as modifier "Ctrl" and simply ignores that part of the String. The resulting shortcut is "L" without the modifier as reported.

Who is the windows guy, likes to fixing the installer?

BTW:
In the *.kbd.conf we will use the untranslated "PortableText" Format, because the keyboard layout has nothing to do with the
text locale.

How does translation of the modifier keys work for Mac OS? Are the Short-cuts shown as "⌘+L"?

<quote>How does translation of the modifier keys work for Mac OS? Are the Short-cuts shown as "⌘+L"? </quote> Yes, "Ctrl" (aka "Strg") translate to "Cmd" (aka "⌘") . See picture.

Cool ;-) Thank you.

I can reproduce the problem on US English Windows XP x64 (running Mixxx with --locale de) but simply dropping qt_de.qm in translations or in the main Mixxx program folder has no effect. How did you get it to work?

Unfortunately I have no Windows development environment, so my findings are based on debugging on Ubuntu.

Please look at mixxx.cpp line 144 ff.

   if( qtTranslator->load("qt_" + locale,
           QLibraryInfo::location(QLibraryInfo::TranslationsPath))) {
       a->installTranslator(qtTranslator);
   }

Where does QLibraryInfo::TranslationsPath points to in WIN?
Maybe the best solution is to load qt_<locale>.qm form "translationsFolder" using a compiler switch.

Under Windows I Test some liens form the Quotation from mixxx.cpp line on Windows. The path "QLibraryInfo::location(QLibraryInfo::TranslationsPath)" shows to the Traslation of the used QT Version.
So the qt_<locale>.qm must be at the same directory as on the compield Version.
An other way could be to set this path to <mixxx_dir>/translation on a Windows PC

I think for Windows and Mac OS X we have to provide these qt files ourselves since we are always providing our own version of Qt with Mixxx. For Linux, we should stick with what QDesktopServices gives us.

But yes, the packaging scripts need updating to include the appropriate qt_ QM files in the same folder the other translations go to (the 'translations' folder)

Actually, I believe no special casing is necessary. We can just create a new QTranslator that searches for qt_*.qm files in the translationsFolder. If none are found then it will have no effect since Qt will just fall back to trying to the QTranslator that uses QDesktopServices.

Added an extra QTranslator as described in #14 to lp:mixxx/1.10

OK, guys. Sorry for the delay on this.
Please check out the Windows builds in http://builds.mixxx.org/builds/release-1.10.x/ and let me know if the problem still exists.

1.10 r3056 for the record.

It works for me on WinXP!

Works on Windows 7 too.

Awesome, thanks guys.

In trunk at least as of r3011.

Mixxx now uses GitHub for bug tracking. This bug has been migrated to:
https://github.com/mixxxdj/mixxx/issues/6207