pkgstriptranslations creates policy-incompliant symlinks

Bug #899520 reported by Evan Broder
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
pkgbinarymangler (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

When pkgstriptranslations replaces files in /usr/share/help, /usr/share/gnome/help, etc. with symlinks to their -langpack counterparts, it creates absolute symlinks.

Since the symlinks will link two files in the same top-level directory, they will always be a violation of Debian Policy Section 10.5 - Symbolic links (http://www.debian.org/doc/debian-policy/ch-files.html#s10.5).

According to data extracted from http://lintian.ubuntuwire.org, there are currently about 22,500 symlinks that violate this policy in the Ubuntu archive:

  udd=# CREATE TABLE ubuntu_only_lintian AS SELECT * FROM ubuntu_lintian EXCEPT SELECT * FROM lintian;
  SELECT 156482
  udd=# SELECT COUNT(tag) AS count FROM ubuntu_only_lintian WHERE tag='symlink-should-be-relative' AND information LIKE '%-langpack%';
   count
  -------
   22509
  (1 row)

(http://lintian.ubuntuwire.org/tags/symlink-should-be-relative.html has the list of all emissions of this tag, though not all of those are unique to Ubuntu and not all of the ones unique to Ubuntu are from pkgstriptranslations)

Related branches

Martin Pitt (pitti)
Changed in pkgbinarymangler (Ubuntu):
status: New → Fix Committed
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package pkgbinarymangler - 110

---------------
pkgbinarymangler (110) precise; urgency=low

  [ Martin Pitt ]
  * pkgstripfiles: Log how many seconds the PNG optimization took.
  * pkgstripfiles: Skip PNG optimization for -doc packages. They sometimes
    take an inordinate amount of build time and are much less important as we
    do not ship them on CD images.

  [ Evan Broder ]
  * pkgstriptranslations: Use a copy of the code from dh_link to make sure
    pkgstriptranslations creates symlinks compliant with Debian
    Policy. (LP: #899520)
  * test/run: Adjust tests to expect relative symlinks.
 -- Martin Pitt <email address hidden> Mon, 12 Dec 2011 12:19:21 +0100

Changed in pkgbinarymangler (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.