innodb_fake_changes doesn't handle duplicate keys on REPLACE
Bug #898306 reported by
Mark Callaghan
This bug affects 3 people
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Percona Server moved to https://jira.percona.com/projects/PS |
Fix Released
|
High
|
Laurynas Biveinis | ||
| 5.1 |
Fix Released
|
High
|
Valentine Gostev | ||
| 5.5 |
Fix Released
|
High
|
Laurynas Biveinis | ||
Bug Description
in sql_insert.
1) try insert
2) if insert fails then do delete and goto #1
When innodb_fake_changes is enabled this gets into an infinite loop.
I attached a patch that applies clean to mysql 5.1.52 + facebook patch. It includes a test case. But I am not sure if Percona likes to modify handler.h.
Related branches
lp:~longbow/percona-server/bug_898306_5.1
- Alexey Kopytov (community): Approve
-
Diff: 173 lines (+120/-0)6 files modifiedPercona-Server/mysql-test/r/percona_innodb_fake_changes_bug_898306.result (+40/-0)
Percona-Server/mysql-test/t/percona_innodb_fake_changes_bug_898306.test (+58/-0)
Percona-Server/sql/handler.h (+6/-0)
Percona-Server/sql/sql_insert.cc (+9/-0)
Percona-Server/storage/innodb_plugin/handler/ha_innodb.cc (+6/-0)
Percona-Server/storage/innodb_plugin/handler/ha_innodb.h (+1/-0)
lp:~laurynas-biveinis/percona-server/bug898306-5.5
- Stewart Smith (community): Approve
-
Diff: 258 lines (+200/-0)7 files modifiedPercona-Server/mysql-test/r/percona_innodb_fake_changes_bug_898306.result (+43/-0)
Percona-Server/mysql-test/t/percona_innodb_fake_changes.test (+75/-0)
Percona-Server/mysql-test/t/percona_innodb_fake_changes_bug_898306.test (+59/-0)
Percona-Server/sql/handler.h (+6/-0)
Percona-Server/sql/sql_insert.cc (+9/-0)
Percona-Server/storage/innobase/handler/ha_innodb.cc (+7/-0)
Percona-Server/storage/innobase/handler/ha_innodb.h (+1/-0)
Revision history for this message
| Mark Callaghan (mdcallag) wrote | #1 |
| Changed in percona-server: | |
| assignee: | nobody → Valentine Gostev (longbow) |
Revision history for this message
| Valentine Gostev (longbow) wrote | #2 |
Revision history for this message
| Valentine Gostev (longbow) wrote | #3 |
| Changed in percona-server: | |
| status: | New → Confirmed |
| importance: | Undecided → High |
Revision history for this message
| Alexey Kopytov (akopytov) wrote | #4 |
Revision history for this message
| Alexey Kopytov (akopytov) wrote | #5 |
| tags: | added: contribution |
Revision history for this message
| Shahriyar Rzayev (rzayev-sehriyar) wrote | #6 |
To post a comment you must log in.
Related bug https:/