Libavcodec has been miscompiled in xine-ffmpeg?

Bug #89537 reported by Sitsofe Wheeler
2
Affects Status Importance Assigned to Milestone
xine-lib (Ubuntu)
Fix Released
Medium
Reinhard Tartler

Bug Description

Description of the problem:
When playing any video through xine-ui that uses ffmpeg a warning is printed on the console.

Steps to reproduce:
(with xine-ui installed)
1. Start a gnome-terminal .
2. Within it run
xine 'http://download.gametrailers.com/gt_vault/t_cc3tw_domination_gp_gt.wmv'

Expected results:
Video to play.

Actual results:
Video plays but a warning is printed on the terminal:
$ xine 'http://download.gametrailers.com/gt_vault/t_cc3tw_domination_gp_gt.wmv'
This is xine (X11 gui) - a free video player v0.99.5cvs.
(c) 2000-2006 The xine Team.
Compiler did not align stack variables. Libavcodec has been miscompiled
and may be very slow or crash. This is not a bug in libavcodec,
but in the compiler. Do not report crashes to FFmpeg developers.

Version information:
Ubuntu Feisty
libxine1 1.1.4-1ubuntu3
libxine1-ffmpeg 1.1.4-1ubuntu3
xine-ui 0.99.4+dfsg+cvs20061111-2ubuntu1

Related branches

Revision history for this message
Reinhard Tartler (siretart) wrote :

well, it's a bit more complicated. xine is compiling ffmpeg as always, but the included copy of ffmpeg now has a check for variable alignment on the stack, which xine disables. I have committed a patch upstream which disables stack alignment. we should probably get this in ubuntu as well, or even better: update the ffmpeg copy and use that.

Changed in xine-lib:
assignee: nobody → siretart
status: Unconfirmed → In Progress
importance: Undecided → Medium
Changed in xine-lib:
status: In Progress → Fix Committed
Revision history for this message
Sitsofe Wheeler (sitsofe) wrote :

Let me just make sure I'm understanding this correctly - your patch disables the warning message ffmpeg does because the warning is spurious?

Revision history for this message
Sitsofe Wheeler (sitsofe) wrote :

Forget the last comment - the changelog makes it perfectly clear:

Don't compile xine with -mpreferred-stack-boundary=2, because ffmpeg expects the stack to be aligned. Patch already aplied Upstream.

Revision history for this message
Reinhard Tartler (siretart) wrote :

built sucessfully on all archs

Changed in xine-lib:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.