bzr hooks shows no name for lazy installed hooks
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Bazaar |
Fix Released
|
Medium
|
Neil Martinsen-Burrell |
Bug Description
Consider the very simple plugin:
"""Test plugin"""
from bzrlib.hooks import install_
def callable():
pass
install_
The relevant portion of the output of "bzr hooks" does not include the string "My name is mud" anywhere:
$ BZR_PLUGINS_
BranchHooks:
automatic_
<no hooks installed>
open:
package-
post_branch_init:
No hook name
No hook name
No hook name
post_
...
"No hook name" is shown thrice (for three plugins that install post_branch_init hooks), but I gave a name when I called install_
I can see where Hooks.hook_lazy() can't call name_hook because it doesn't have a callable to use as the key in self._callable_
Related branches
- Martin Pool: Approve
-
Diff: 98 lines (+41/-1)3 files modifiedbzrlib/hooks.py (+16/-1)
bzrlib/tests/blackbox/test_hooks.py (+22/-0)
doc/en/release-notes/bzr-2.5.txt (+3/-0)
Changed in bzr: | |
assignee: | nobody → Neil Martinsen-Burrell (nmb) |
status: | Confirmed → In Progress |
milestone: | none → 2.5b4 |
Changed in bzr: | |
status: | In Progress → Fix Released |
that makes sense to me
status confirmed
importance medium