Inconsistent names for built-in fixtures
Bug #893539 reported by
Jonathan Lange
This bug affects 1 person
| Affects | Status | Importance | Assigned to | Milestone | |
|---|---|---|---|---|---|
| Python Fixtures |
Fix Released
|
Undecided
|
Jonathan Lange | ||
Bug Description
These are the built-in fixtures:
* EnvironmentVari
* MonkeyPatch
* PackagePathEntry
* PopenFixture
* PythonPackage
* PythonPathEntry
* TempDir
Two have names that end with "Fixture". It's not clear why they do and others don't. It also makes it hard to guess the right name, and guessability is awesome.
Probably none of these should have names ending in "Fixture". Note that this would leave something called "Popen", which seems like it could be confused with subprocess.Popen. For that, I'd suggest PopenDouble or FakePopen or something similar.
Related branches
lp:~jml/python-fixtures/normal-names-893539
- python-fixtures committers: Pending requested
-
Diff: 505 lines (+96/-64)10 files modifiedNEWS (+5/-1)
README (+15/-15)
lib/fixtures/__init__.py (+7/-2)
lib/fixtures/_fixtures/__init__.py (+16/-4)
lib/fixtures/_fixtures/environ.py (+8/-4)
lib/fixtures/_fixtures/logger.py (+8/-4)
lib/fixtures/_fixtures/popen.py (+8/-3)
lib/fixtures/tests/_fixtures/test_environ.py (+13/-14)
lib/fixtures/tests/_fixtures/test_logger.py (+10/-10)
lib/fixtures/tests/_fixtures/test_popen.py (+6/-7)
| Changed in python-fixtures: | |
| status: | New → Fix Released |
| assignee: | nobody → Jonathan Lange (jml) |
| milestone: | none → next |
To post a comment you must log in.
