cobbler-ubuntu-import fails to import if ISO_DIR is missing

Bug #892409 reported by Adam Gandelman
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
cobbler (Ubuntu)
Fix Released
Undecided
Unassigned

Bug Description

If $ISO_DIR is missing for some reason, cobbler-ubuntu-import fails to import distros.

Log: http://paste.ubuntu.com/742843/

It seems there is a bad if clause when determing whether or not to check for and create the directory.

Related branches

Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package cobbler - 2.2.2-0ubuntu5

---------------
cobbler (2.2.2-0ubuntu5) precise; urgency=low

  * debian/cobbler-ubuntu-import: Support wget'ing via a proxy via -p argument,
    correct error so that $ISO_DIR actually gets created if it doesn't exist.
    (LP: #892409)
 -- Adam Gandelman <email address hidden> Tue, 22 Nov 2011 15:36:38 -0500

Changed in cobbler (Ubuntu):
status: New → Fix Released
Revision history for this message
Scott Moser (smoser) wrote :

fwiw, I'm guessing that the http proxy code that was committed under this bug would have been doable via 'http_proxy' environment variable, which is fairly widely known and respected (by wget and apt at least).

Revision history for this message
Scott Moser (smoser) wrote :

oh, and now i see it *does* use that variable, so i'm only curious now why adding a flag was deemed superior to just using the environment variable (as wget would have used).

Revision history for this message
Adam Gandelman (gandelman-a) wrote :

Scott-

I opted for a new flag since the main user of this script so far is orchestra-import-isos. I'd rather it pass the '-p' flag depending on its configuration, rather than exporting an environment variable and hope that cobbler-ubuntu-import is still using something like wget that respects it. Whether or not orchestra-import-isos wants to use a proxy should be passed as input to cobbler-ubuntu-import, not some tool its currently using internally. Personally, I think the use of 'wget $URL1 || wget $URL2' is a bit clunky and wouldn't mind seeing that rewritten at some point in the future using something a bit more flexible than wget (curl, httplib).

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.