Inverse transformation from output projection to Thoby input image is wrong

Bug #891912 reported by Timothee Groleau
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Hugin
Won't Fix
Undecided
Unassigned
Panotools
Fix Released
Undecided
Unassigned

Bug Description

pto attached that highlights the problem.

email sent to hugin-ptx yesterday:

===================================
Hi there!

I'm experiencing a very weird behavior in hugin 2011.2.0 on a gentoo
64 box. I have a 360 pano of 15 shots taken with a full frame fisheye
10.5mm. There are so many shots because I am doing a clone photography
experiment of the same subject several times in the pano.

I've set up masks accordingly to include the subject in all relevant
shots. masks do not overlap accross shots.

For 2 of the shots, where the subject is roughly 180 degree from
himself, enabling both pics at the same time with masks gives me a
completely wrong masking result (both in hugin and as exported by nona
on stitching).

I have a taken a few screenshots showing the problem here:
http://timotheegroleau.com/bugs/20111116_hugin_mask/

note the incorrect render when both pics are activated simultaneously.

Has anyone experienced this before? How can I troubleshoot and fix
this?

Thanks in advance!
Tim
===================================

reply from Bruno Postle
===================================
Yes we have seen and fixed similar bugs with masks and fisheye
photos before. The workaround is to just edit the mask and move
some nodes, the problem should go away.

..but before you do that please save the .pto file and attach it to a
bug report on launchpad: https://bugs.launchpad.net/hugin/+filebug
===================================

I have tried to edit the masks to be as close as possible to the subjects outline, I can't get the problem to go away :(

Revision history for this message
Timothee Groleau (tg-z) wrote :
Revision history for this message
Bruno Postle (brunopostle) wrote :

Confirmed with 2011.3.0 2011-10-31hg on Linux. I'll attach a reduced 2-image project with dummy photos that shows the problem.

Changed in hugin:
status: New → Confirmed
Revision history for this message
tmodes (tmodes) wrote :

I had a look on the project. The issue with the mask has nothing to do with the mask handling,
I
t reveals a bug in libpano (I assume). The (inverse) transformation from equirectangular (or other output projection) to Thoby fisheye (input) images is not correct. This needs to be fixed in libpano.

2 observation:
1.) when changing to a other fisheye projection the mask is correct.
2.) When output a remapped image from Thoby fisheye the output contains a cross opposite the image (if the image is at yaw 0 there is a cross at yaw 180). This is visible in the (normal) preview window and also in the remapped images.

summary: - Mask rendering issue with full-frame fisheye lens for 360 pano
+ Inverse transformation from output projection to Thoby input image is
+ wrong
Revision history for this message
tmodes (tmodes) wrote :

Attached patch fixes the incorrect transformation.

Revision history for this message
Bruno Postle (brunopostle) wrote :

Thanks applied to panotools SVN r1350

Changed in panotools:
status: New → Fix Committed
Changed in hugin:
status: Confirmed → Fix Committed
tmodes (tmodes)
Changed in hugin:
status: Fix Committed → Won't Fix
tmodes (tmodes)
Changed in panotools:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Patches

Remote bug watches

Bug watches keep track of this bug in other bug trackers.