Percona XtraBackup moved to https://jira.percona.com/projects/PXB

tar4ibd crashes on multi-file tablespace files

Bug #891496 reported by Alexey Kopytov
10
This bug affects 2 people
Affects Status Importance Assigned to Milestone
Percona XtraBackup moved to https://jira.percona.com/projects/PXB
Fix Released
Undecided
Alexey Kopytov
Percona XtraBackup moved to https://jira.percona.com/projects/PXB 1.9.1
1.6
Fix Released
Undecided
Alexey Kopytov
Percona XtraBackup moved to https://jira.percona.com/projects/PXB 1.6.5
2.0
Fix Released
Undecided
Alexey Kopytov
Percona XtraBackup moved to https://jira.percona.com/projects/PXB 1.9.1

Bug Description

tar4ibd may crash on data files in a multi-file system tablespace configuration.

The reason is that tar4ibd expects to read page size from the FSP header of each data file, which, in case of a multi-file system tablespace, is only available in the first file, but not in subsequent ones. For example, for innodb_data_file_path=ibdata1:2000M;ibdata2:10M:autoextend, only ibdata1 will have an FSP header and thus flags, they will be missing in ibdata2. That results in tar4ibd using a bogus page size, hence the crash.

See original description

Related branches

lp:~akopytov/percona-xtrabackup/bug891496-1.6
Stewart Smith (community): Approve
Diff: 75 lines (+50/-3)
2 files modified
patches/tar4ibd_libtar-1.2.11.patch (+3/-3)
test/t/bug891496.sh (+47/-0)
lp:~akopytov/percona-xtrabackup/bug891496-1.7
Stewart Smith (community): Approve
Diff: 75 lines (+50/-3)
2 files modified
patches/tar4ibd_libtar-1.2.11.patch (+3/-3)
test/t/bug891496.sh (+47/-0)
Revision history for this message
Alexey Kopytov (akopytov) wrote :

There are more details in issue #18185.

Revision history for this message
Stewart Smith (stewart) wrote : Re: [Bug 891496] [NEW] Test tar4ibd on 5.0 data files

On Thu, 17 Nov 2011 06:47:16 -0000, Alexey Kopytov <email address hidden> wrote:
> There is a report that tar4ibd may crash on datafiles produced by 5.0.
> We have to test it by running some streaming backups tests against 5.0,
> both MySQL and Percona Server and fix any issues we may find.

Maybe assign to Patrick to be able to come up with test/infrastructure
to also run against 5.0.

--
Stewart Smith

Revision history for this message
Patrick Crews (patrick-crews) wrote : Re: Test tar4ibd on 5.0 data files

Assigning to myself while I cook up a testcase. Shouldn't be too terrible to make this happen.

Changed in percona-xtrabackup:
assignee: nobody → Patrick Crews (patrick-crews)
Alexey Kopytov (akopytov)
Changed in percona-xtrabackup:
assignee: Patrick Crews (patrick-crews) → Alexey Kopytov (akopytov)
status: New → In Progress
Revision history for this message
Alexey Kopytov (akopytov) wrote :

Could reproduce the crash on a 5.0 data file provided by a customer.

summary: - Test tar4ibd on 5.0 data files
+ tar4ibd fails on datafiles generated on 5.0
Revision history for this message
Alexey Kopytov (akopytov) wrote : Re: tar4ibd fails on datafiles generated on 5.0

This bug is in fact not specific to 5.0-generated files. Any server using a multi-file system tablespace is affected.

The reason is that tar4ibd expects to read page size from the FSP header of each data file, which, in case of a multi-file system tablespace, is only available in the first file, but not in subsequent ones. For example, for innodb_data_file_path=ibdata1:2000M;ibdata2:10M:autoextend, only ibdata1 will have an FSP header and thus flags, they will be missing in ibdata2. That results in tar4ibd using a bogus page size, hence the crash.

Changing summary and description to reflect the above.

summary: - tar4ibd fails on datafiles generated on 5.0
+ tar4ibd crashes on multi-file tablespace files
description: updated
Revision history for this message
Shahriyar Rzayev (rzayev-sehriyar) wrote :

Percona now uses JIRA for bug reports so this bug report is migrated to: https://jira.percona.com/browse/PXB-1138

To post a comment you must log in.
This report contains Public information  
Everyone can see this information.
Subscribing...

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.