renaming of api_key causes several unhandled exceptions

The rename does fix it, but I think the real issue is that we shouldn't be sending the auth_token in as "password"

The bug seems to have happened here: https://github.com/openstack/python-novaclient/commit/c386221bd8f757fe98abd076d21f3a1fdd9712e2

perhaps we should not used named parameters?

Should we roll back the nova-client change (just of the named parameters for that function) until a patch like this is released?

Hm. It does seem like callers should not use keyword arguments, since they are not optional...

If it helps, I'm okay renaming the argument back for a while.

ALSO: NOVA_API_KEY environment variable changed to NOVA_PASSWORD... which is incompatible with the novarc template in nova diablo... and even still in nova master. Suspect I might need to revert the patchset that made these changes.

There is a conflation of password and api_key in novaclient which is inappropriate. If you take a look at python-keystoneclient, I actually separated the two because there are cases (at least in keystone) where they need to be handled differently.

Positional arguments are easier for making things "required" but also get ugly for backwards compatibility across changes to the function signature. Keyword arguments are both easier to work with (you don't have to memorize the order) and more forwards-compatible. If you want t make them required, just raise a ValueError if a required keyword argument is present.

Gabriel: Sure. I just want to get some sort of fix in ASAP and we can figure out the right thing afterwards.

Jesse: https://review.openstack.org/#change,1734

Reviewed: https://review.openstack.org/1734
Committed: http://github.com/openstack/python-novaclient/commit/0e1e38d2e43fddb90b8010bd3e43b3da641cf643
Submitter: Jenkins
Branch: master

 status fixcommitted
 done

commit 0e1e38d2e43fddb90b8010bd3e43b3da641cf643
Author: Chris Behrens <email address hidden>
Date: Thu Nov 17 12:48:58 2011 -0800

    Revert api_key change in novaclient Client argument

    Fixes bug 891442

    Also, still need to support NOVA_API_KEY environment variable for now.
    Bump version to 2.6.8 so we can get this into pypi
    Updated setup.py to build properly

    Change-Id: I16233ac559bf44b78666118d68975509da6bfb0d

And I just pushed novaclient version 2.6.8 to pypi.

should horizon go ahead and switch to positional parameters for this call so we can revert the revert eventually?

I think so... or we can wait to figure out what the novaclient interface really should be. Passing in password or auth_token as keyword arguments might certainly be appealing if there ends up being different functionality based on which one is passed.

Whatever happened here, this has been long-since resolved and is no longer an issue.