Windows: test failure at tests.syncdaemon.test_action_queue.TestZipQueue.test_compress_gets_compressed_data

Bug #887150 reported by Natalia Bidart
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
Ubuntu One Client
Fix Released
High
Natalia Bidart

Bug Description

===============================================================================
[FAIL]
Traceback (most recent call last):
  File "C:\Python27\lib\site-packages\twisted\internet\defer.py", line 1020, in _inlineCallbacks
    result = g.send(result)
  File "E:\client\is-running-needs-yielding\tests\syncdaemon\test_action_queue.py", line 1045, in test_compress_gets_compressed_data
    self.assertEqual(compressed, data.encode('zip'))
twisted.trial.unittest.FailTest: not equal:
a = ''
b = 'x\x9cKT\xc8\xc9/Q\xc8OSHI,IT(\xc9WH\xce\xcf-(J-.\x06\x00o\xb2\t\x0f'

tests.syncdaemon.test_action_queue.TestZipQueue.test_compress_gets_compressed_data

Tags: u1-windows

Related branches

Revision history for this message
Natalia Bidart (nataliabidart) wrote :

This is in fact a bug in the code, since the file descriptor f, which is created in action_queue.ZipQueue._compress, is never closed, so the content is not fully written to it when the deferred is fired.

Changed in ubuntuone-client:
assignee: nobody → Natalia Bidart (nataliabidart)
importance: Undecided → High
status: New → In Progress
tags: added: u1-windows
Changed in ubuntuone-client:
status: In Progress → Triaged
Changed in ubuntuone-client:
status: Triaged → In Progress
Changed in ubuntuone-client:
status: In Progress → Fix Committed
Changed in ubuntuone-client:
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.