flaky test

Bug #884427 reported by John A Meinel
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
U1DB
Invalid
High
Unassigned

Bug Description

We have a test that fails occasionally:
$ make
python -m testtools.run discover
Tests running...
----------------------------------------
Exception happened during processing of request from ('127.0.0.1', 47554)
Traceback (most recent call last):
  File "/home/jameinel/dev/u1db/work/u1db/remote/sync_server.py", line 55, in process_request_thread
    self.finish_request(request, client_address)
  File "/usr/lib/python2.7/SocketServer.py", line 323, in finish_request
    self.RequestHandlerClass(request, client_address, self)
  File "/usr/lib/python2.7/SocketServer.py", line 639, in __init__
    self.handle()
  File "/home/jameinel/dev/u1db/work/u1db/tests/test_remote_sync_server.py", line 48, in handle
    value = self.request.recv(1024)
  File "/usr/lib/python2.7/socket.py", line 170, in _dummy
    raise error(EBADF, 'Bad file descriptor')
error: [Errno 9] Bad file descriptor
----------------------------------------

I'm pretty sure this is just shutdown code that is triggering, and the socket is already closed by the time we go to check for the next request, etc.

Really we should just handle EBADF and exit without reporting an error.

Related branches

Revision history for this message
John A Meinel (jameinel) wrote :

This doesn't actually fail the test suite, it just causes stipple on the output, but it would be nice to never do that.

Changed in u1db:
importance: Undecided → High
status: New → Confirmed
John A Meinel (jameinel)
summary: - flakey test
+ flaky test
Revision history for this message
Samuele Pedroni (pedronis) wrote :

the affected code is not in the code base anymore

Changed in u1db:
status: Confirmed → Invalid
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.