racey test canonical/lazr/doc/pidfile.txt: "pid file was not removed"
Affects | Status | Importance | Assigned to | Milestone | |
---|---|---|---|---|---|
Launchpad itself |
Fix Released
|
Critical
|
Martin Pool |
Bug Description
when trying to land https:/
I hit
Failing tests
-------------
pidfile_txt
=======
FAILURE: pidfile_txt (subunit.
-------
_StringException: Text attachment: traceback
------------
Traceback (most recent call last):
File "/usr/lib/
testMethod()
File "/usr/lib/
raise self.failureExc
AssertionError: Failed doctest test for pidfile.txt
File "/var/launchpad
-------
File "/var/launchpad
Failed example:
stop(pid, signal.SIGTERM)
Differences (ndiff with -expected +actual):
- Stopped successfully
+ Error: pid file was not removed
------------
Muharem hit the same problem back in 2009, according to my mail archive, so I guess it's a timing dependent bug.
Related branches
- Robert Collins (community): Approve
-
Diff: 35 lines (+11/-2)1 file modifiedlib/canonical/lazr/doc/pidfile.txt (+11/-2)
Changed in launchpad: | |
importance: | Undecided → Critical |
status: | New → Triaged |
Changed in launchpad: | |
status: | Triaged → In Progress |
assignee: | nobody → Martin Pool (mbp) |
tags: |
added: qa-untestable removed: qa-needstesting |
tags: | added: spurious-test-failure |
Changed in launchpad: | |
status: | Fix Committed → Fix Released |
The test code loops for 2 seconds on the existing of the pid file, and the test helper sleeps for 30 seconds. I suspect a race in there.