mk-sbuild needs better http proxy support

Bug #881654 reported by Scott Moser
6
This bug affects 1 person
Affects Status Importance Assigned to Milestone
ubuntu-dev-tools (Ubuntu)
Fix Released
Wishlist
Scott Moser

Bug Description

right now mk-sbuild has minimal support for using an apt proxy.
Looking at history, in theory this was fixed under bug 416438, but I don't really understand how.

during a 'mk-sbuild' run, such as:
  ./mk-sbuild --debootstrap-mirror http://us.archive.ubuntu.com/ubuntu --arch amd64 precise

There are at least 3 places where a proxy would be necessary:
 a.) initial invocation of debootstrap
   currently:
    sudo "$DEBOOTSTRAP_COMMAND" --arch="$CHROOT_ARCH" \
       $variant_opt $debootstrap_opts "$RELEASE" \
       "$MNT" "${DEBOOTSTRAP_MIRROR:-http://archive.ubuntu.com/ubuntu}"
 b.) the 'finish.sh' script that is invoked inside the chroot after initializing
 c.) subsequent uses of that schroot

The only place in which 'http_proxy' environment variable is respected as far as I can tell is in 'b'.
 a.) http_proxy environment does not make it through 'sudo' by default.
 c.) creating a new schroot session like:
     http_proxy=myfooproxy schroot --chroot precise-amd64 --begin-session --session-name foobar
     http_proxy=myfooproxy schroot --run-session --chroot foobar

     the http_proxy variable does not make it through in either case.

ProblemType: Bug
DistroRelease: Ubuntu 11.10
Package: ubuntu-dev-tools 0.132ubuntu0.1
ProcVersionSignature: Ubuntu 3.0.0-12.20-generic 3.0.4
Uname: Linux 3.0.0-12-generic x86_64
ApportVersion: 1.23-0ubuntu3
Architecture: amd64
Date: Tue Oct 25 16:00:44 2011
EcryptfsInUse: Yes
InstallationMedia: Ubuntu 11.10 "Oneiric Ocelot" - Release amd64 (20111012)
PackageArchitecture: all
ProcEnviron:
 PATH=(custom, user)
 LANG=en_US.UTF-8
 SHELL=/bin/bash
SourcePackage: ubuntu-dev-tools
UpgradeStatus: No upgrade log present (probably fresh install)

Revision history for this message
Scott Moser (smoser) wrote :
Scott Moser (smoser)
description: updated
Revision history for this message
Stefano Rivera (stefanor) wrote :

Environment variables not making it through sudo by default is a relatively recent change, isn't it?

Yeah, we can pass it around a little more explicitly. Care to provide a patch?

Changed in ubuntu-dev-tools (Ubuntu):
status: New → Fix Committed
importance: Undecided → Wishlist
assignee: nobody → Scott Moser (smoser)
Revision history for this message
Launchpad Janitor (janitor) wrote :

This bug was fixed in the package ubuntu-dev-tools - 0.134

---------------
ubuntu-dev-tools (0.134) unstable; urgency=low

  [ Stefano Rivera ]
  * mk-sbuild: Correct typo in variable name. Thanks Laurent Declercq.
    (Closes: #645917)
  * Remove massfile. Neglected and unused (LP: #145598)
  * syncpackage, requestsync: Sync from testing for LTSs (LP: #876400)
  * syncpackage:
    - Ignore CURRENT blacklisting: it's buggy, and we don't have a good use
      for it.
    - Always display blacklist comments, if they exist.
    - Display timestamps for DSD blacklist comments.
    - Add --fakesync option, relegating --no-lp to really crazy corner cases.
  * sponsor-patch: Compare new sync version to the current Ubuntu version,
    rather than itself (LP: #878499)
  * sponsor-patch.1: Mention syncs (LP: #882085)

  [ Benjamin Drung ]
  * syncpackage: Catch user abort.

  [ Scott Moser ]
  * mk-sbuild: better support apt http proxy (LP: #881654)

 -- Stefano Rivera <email address hidden> Fri, 28 Oct 2011 10:16:15 +0200

Changed in ubuntu-dev-tools (Ubuntu):
status: Fix Committed → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.