Cache system for notifications not working properly

Bug #881437 reported by zorun
12
This bug affects 2 people
Affects Status Importance Assigned to Milestone
byobu
Fix Released
High
Unassigned

Bug Description

I was trying to figure out two issues:
* notifications were freezing quite often with tmux
* byobu-tmux eats up a lot more CPU than byobu-screen

It turns out that the cache is not working properly, thus leading every notification to be triggered at each refresh. I'm not sure why this is causing the freeze, but it looks like the cause of the second issue.

To see the problem:
cat /dev/shm/byobu-*/.last.tmux/*

In my case, all the files have a content of "0".

The issue comes from the 'get_now' function in usr/lib/byobu/.shutil, which relies on $SECONDS. This variable does not seem to be usable in this context, as 'get_now' always returns 0.
See:
bash -x /usr/bin/byobu-status tmux_right 2>&1 | grep NOW

Related branches

Revision history for this message
Dustin Kirkland  (kirkland) wrote :

Hi zorun,

I think these issues are fix-released. I merged your proposed branch related to this bug. $SECONDS is no longer used anywhere in the byobu code base. And I'm not able to reproduce the get_now returning 0 problem anymore.

Can you give the latest release a try and reopen this bug with more details if it's still an issue? Thanks for the report!

Dustin

Changed in byobu:
importance: Undecided → High
status: New → Fix Released
To post a comment you must log in.
This report contains Public information  
Everyone can see this information.

Other bug subscribers

Remote bug watches

Bug watches keep track of this bug in other bug trackers.